[
https://issues.apache.org/jira/browse/DRILL-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011510#comment-15011510
]
ASF GitHub Bot commented on DRILL-4015:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/263#discussion_r45233292
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/exception/DrillWarningHelper.java
---
@@ -0,0 +1,123 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.exception;
+
+import com.google.common.collect.Lists;
+import org.apache.drill.exec.proto.UserBitShared.WarningMsg;
+
+import java.util.IdentityHashMap;
+import java.util.List;
+
+/**
+ * Helper class to manage warnings for FragmentContext and Foreman
+ */
+public class DrillWarningHelper {
+
+ private List<IdentityHashMap<String, WarningMsg>> warnings;
+ private String fragmentId;
+ int numWarnings = 0;
+
+ public DrillWarningHelper (String fragmentId) {
+ this.warnings = Lists.newArrayList();
+ this.fragmentId = fragmentId;
+ }
+
+ /**
+ * Interface for operators to add warnings
+ * @param operatorId operator warning is coming from
+ * @param type pre-defined warning type
+ * @param msg custom warning message
+ */
+ public void addWarning (int operatorId, String type, String msg) {
+ assert (operatorId >= 0 && type != null);
+
+ IdentityHashMap<String, WarningMsg> warningMap = null;
--- End diff --
unnecessary null
> Update DrillClient and JDBC driver to expose warnings provided via RPC layer
> ----------------------------------------------------------------------------
>
> Key: DRILL-4015
> URL: https://issues.apache.org/jira/browse/DRILL-4015
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Client - JDBC, Execution - RPC
> Reporter: Jacques Nadeau
> Assignee: Abhijit Pol
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
