[
https://issues.apache.org/jira/browse/DRILL-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034169#comment-15034169
]
ASF GitHub Bot commented on DRILL-4134:
---------------------------------------
Github user julienledem commented on a diff in the pull request:
https://github.com/apache/drill/pull/283#discussion_r46310977
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -252,32 +282,25 @@ public int capacity() {
}
@Override
- public synchronized ByteBuf capacity(int newCapacity) {
- if (rootBuffer) {
- if (newCapacity == length) {
- return this;
- } else if (newCapacity < length) {
- b.capacity(newCapacity);
- int diff = length - b.capacity();
- acct.releasePartial(this, diff);
- this.length = length - diff;
- return this;
- } else {
- throw new UnsupportedOperationException("Accounting byte buf
doesn't support increasing allocations.");
- }
- } else {
- throw new UnsupportedOperationException("Non root bufs doen't
support changing allocations.");
+ public synchronized DrillBuf capacity(int newCapacity) {
--- End diff --
nevermind, it overrides a netty method.
> Incorporate remaining patches from DRILL-1942 Allocator refactor
> ----------------------------------------------------------------
>
> Key: DRILL-4134
> URL: https://issues.apache.org/jira/browse/DRILL-4134
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Execution - Flow
> Reporter: Jacques Nadeau
> Assignee: Jacques Nadeau
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
