[ https://issues.apache.org/jira/browse/DRILL-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055599#comment-15055599 ]
ASF GitHub Bot commented on DRILL-4134: --------------------------------------- Github user julienledem commented on a diff in the pull request: https://github.com/apache/drill/pull/283#discussion_r47469236 --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java --- @@ -431,12 +482,18 @@ public boolean equals(Object obj) { } @Override - public synchronized ByteBuf retain(int increment) { - if(rootBuffer){ - this.rootRefCnt.addAndGet(increment); - }else{ - b.retain(increment); + public ByteBuf retain(int increment) { --- End diff -- Do you intend to remove it before merging? > Incorporate remaining patches from DRILL-1942 Allocator refactor > ---------------------------------------------------------------- > > Key: DRILL-4134 > URL: https://issues.apache.org/jira/browse/DRILL-4134 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Flow > Reporter: Jacques Nadeau > Assignee: Jacques Nadeau > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)