[ 
https://issues.apache.org/jira/browse/DRILL-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111154#comment-15111154
 ] 

ASF GitHub Bot commented on DRILL-4295:
---------------------------------------

Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/333#issuecomment-173683725
  
    Fair question. For the first year the codebase only generated these files 
at build time (no check-in). In this situation newcomers had to install the 
right version of protoc. This turned into the single biggest issue on the dev 
list to new contributors. As such, we finally relented and committed the 
compiled code. (In general, the problem is that if brew/macports installs the 
wrong version, people get strange maven compilation problems that are 
non-obvious). 


> Obsolete protobuf generated files under protocol/
> -------------------------------------------------
>
>                 Key: DRILL-4295
>                 URL: https://issues.apache.org/jira/browse/DRILL-4295
>             Project: Apache Drill
>          Issue Type: Task
>          Components: Tools, Build & Test
>            Reporter: Laurent Goujon
>            Priority: Trivial
>
> The following two files don't have a protobuf definition anymore, and are not 
> generated when running {{mvn process-sources -P proto-compile}} under 
> {{protocol/}}:
> {noformat}
> src/main/java/org/apache/drill/exec/proto/beans/RpcFailure.java
> src/main/java/org/apache/drill/exec/proto/beans/ViewPointer.java
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to