[ https://issues.apache.org/jira/browse/DRILL-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147910#comment-15147910 ]
ASF GitHub Bot commented on DRILL-4275: --------------------------------------- Github user hnfgns commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52954240 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreProvider.java --- @@ -17,17 +17,26 @@ */ package org.apache.drill.exec.store.sys; -import java.util.Map; - +import org.apache.drill.exec.exception.StoreException; /** - * Interface for reading and writing values to a persistent storage provider. Iterators are guaranteed to be returned in key order. - * @param <V> + * A factory used to create {@link PersistentStore store} instances. + * */ -public interface PStore<V> extends Iterable<Map.Entry<String, V>> { - public V get(String key); - public void put(String key, V value); - public boolean putIfAbsent(String key, V value); - public void delete(String key); - public void close(); +public interface PersistentStoreProvider extends AutoCloseable { + /** + * Gets or creates a {@link PersistentStore persistent store} for the given configuration. + * + * Note that implementors have liberty to cache previous {@link PersistentStore store} instances. + * + * @param config store configuration + * @param <V> store value type + */ + <V> PersistentStore<V> getStore(PersistentStoreConfig<V> config) throws StoreException; --- End diff -- done. > Refactor e/pstore interfaces and their factories to provide a unified > mechanism to access stores > ------------------------------------------------------------------------------------------------ > > Key: DRILL-4275 > URL: https://issues.apache.org/jira/browse/DRILL-4275 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Flow > Reporter: Hanifi Gunes > Assignee: Deneche A. Hakim > > We rely on E/PStore interfaces to persist data. Even though E/PStore stands > for Ephemeral and Persistent stores respectively, the current design for > EStore does not extend the interface/functionality of PStore at all, which > hints abstraction for EStore is redundant. This issue proposes a new unified > Store interface replacing the old E/PStore that exposes an additional method > that report persistence level as follows: > {code:title=Store interface} > interface Store<V> { > StoreMode getMode(); > V get(String key); > ... > } > enum StoreMode { > EPHEMERAL, > PERSISTENT, > ... > } > {code} > The new design brings in less redundancy, more centralized code, ease to > reason and maintain. -- This message was sent by Atlassian JIRA (v6.3.4#6332)