[ https://issues.apache.org/jira/browse/DRILL-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15147987#comment-15147987 ]
ASF GitHub Bot commented on DRILL-4275: --------------------------------------- Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/374#discussion_r52960717 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/PersistentStoreMode.java --- @@ -6,22 +6,18 @@ * to you under the Apache License, Version 2.0 (the * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at - * + * <p/> * http://www.apache.org/licenses/LICENSE-2.0 - * + * <p/> * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ - package org.apache.drill.exec.store.sys; - -/** - * Interface to define the provider which return EStore. - */ - -public interface EStoreProvider extends PStoreProvider { +public enum PersistentStoreMode { --- End diff -- javadoc > Refactor e/pstore interfaces and their factories to provide a unified > mechanism to access stores > ------------------------------------------------------------------------------------------------ > > Key: DRILL-4275 > URL: https://issues.apache.org/jira/browse/DRILL-4275 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Flow > Reporter: Hanifi Gunes > Assignee: Deneche A. Hakim > > We rely on E/PStore interfaces to persist data. Even though E/PStore stands > for Ephemeral and Persistent stores respectively, the current design for > EStore does not extend the interface/functionality of PStore at all, which > hints abstraction for EStore is redundant. This issue proposes a new unified > Store interface replacing the old E/PStore that exposes an additional method > that report persistence level as follows: > {code:title=Store interface} > interface Store<V> { > StoreMode getMode(); > V get(String key); > ... > } > enum StoreMode { > EPHEMERAL, > PERSISTENT, > ... > } > {code} > The new design brings in less redundancy, more centralized code, ease to > reason and maintain. -- This message was sent by Atlassian JIRA (v6.3.4#6332)