[ https://issues.apache.org/jira/browse/DRILL-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220463#comment-15220463 ]
ASF GitHub Bot commented on DRILL-2100: --------------------------------------- Github user jaltekruse commented on a diff in the pull request: https://github.com/apache/drill/pull/454#discussion_r58108889 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/ExternalSortBatch.java --- @@ -110,11 +111,12 @@ private LinkedList<BatchGroup> batchGroups = Lists.newLinkedList(); private LinkedList<BatchGroup> spilledBatchGroups = Lists.newLinkedList(); private SelectionVector4 sv4; - private FileSystem fs; + private static FileSystem fs; --- End diff -- looks like the github markdown killed part of you message, it did get through to the email they sent out, copied modified versions of the paths here: root spill dir / query_id / major_frag_id / minor_frag_id / operator_id/ Instead we should make it: root spill dir / query_id__major_frag_id__minor_frag_id__operator_id / I don't think we need the double underscores in the path, I just did that to separate the components of the directory name. > Drill not deleting spooling files > --------------------------------- > > Key: DRILL-2100 > URL: https://issues.apache.org/jira/browse/DRILL-2100 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Relational Operators > Affects Versions: 0.8.0 > Reporter: Abhishek Girish > Assignee: Vitalii Diravka > Fix For: Future > > > Currently, after forcing queries to use an external sort by switching off > hash join/agg causes spill-to-disk files accumulating. > This causes issues with disk space availability when the spill is configured > to be on the local file system (/tmp/drill). Also not optimal when configured > to use DFS (custom). > Drill must clean up all temporary files created after a query completes or > after a drillbit restart. -- This message was sent by Atlassian JIRA (v6.3.4#6332)