[
https://issues.apache.org/jira/browse/DRILL-4576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228790#comment-15228790
]
ASF GitHub Bot commented on DRILL-4576:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/466#discussion_r58754467
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/PlannerCallback.java
---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner;
+
+import java.util.Collection;
+
+import org.apache.calcite.plan.RelOptPlanner;
+
+/**
+ * A callback that StoragePlugins can initialize to allow further
configuration
+ * of the Planner at initialization time. Examples could be to allow
adding lattices,
+ * materializations or additional traits to the planner that will be used
in
+ * planning.
+ */
+public abstract class PlannerCallback {
+
+ /**
+ * Method that will be called before a planner is used to further
configure the planner.
+ * @param planner The planner to be configured.
+ */
+ public abstract void initializePlanner(RelOptPlanner planner);
+
+
+ public static PlannerCallback merge(Collection<PlannerCallback>
callbacks){
+ return new PlannerCallbackCollection(callbacks);
+ }
+
+ private static class PlannerCallbackCollection extends PlannerCallback{
+ private Collection<PlannerCallback> callbacks;
+
+ private PlannerCallbackCollection(Collection<PlannerCallback>
callbacks){
+ this.callbacks = callbacks;
--- End diff --
should a immutable copy be used instead of the caller's collection?
> Add StoragePlugin API to register materialization into planner
> --------------------------------------------------------------
>
> Key: DRILL-4576
> URL: https://issues.apache.org/jira/browse/DRILL-4576
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Laurent Goujon
> Assignee: Jacques Nadeau
>
> There's no currently a good way to register materializations into Drill
> planner. Calcite's MaterializationService.instance() would be the way to go,
> but the registration happens in
> {{org.apache.calcite.prepare.Prepare.PreparedResult#prepareSql()}}, which is
> not called by Drill.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
