[ https://issues.apache.org/jira/browse/DRILL-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263330#comment-15263330 ]
ASF GitHub Bot commented on DRILL-4132: --------------------------------------- Github user yufeldman commented on a diff in the pull request: https://github.com/apache/drill/pull/368#discussion_r61523924 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/user/PlanSplitter.java --- @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.work.user; + +import java.util.List; + +import org.apache.drill.exec.ops.QueryContext; +import org.apache.drill.exec.physical.PhysicalPlan; +import org.apache.drill.exec.physical.base.PhysicalOperator; +import org.apache.drill.exec.planner.fragment.Fragment; +import org.apache.drill.exec.planner.fragment.MakeFragmentsVisitor; +import org.apache.drill.exec.planner.fragment.SimpleParallelizer; +import org.apache.drill.exec.planner.fragment.contrib.SimpleParallelizerMultiPlans; +import org.apache.drill.exec.planner.sql.DrillSqlWorker; +import org.apache.drill.exec.proto.BitControl.PlanFragment; +import org.apache.drill.exec.proto.UserBitShared.DrillPBError; +import org.apache.drill.exec.proto.UserBitShared.QueryId; +import org.apache.drill.exec.proto.UserBitShared.QueryResult.QueryState; +import org.apache.drill.exec.proto.UserProtos.GetQueryPlanFragments; +import org.apache.drill.exec.proto.UserProtos.QueryPlanFragments; +import org.apache.drill.exec.rpc.user.UserServer.UserClientConnection; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.util.MemoryAllocationUtilities; +import org.apache.drill.exec.util.Pointer; +import org.apache.drill.exec.util.Utilities; +import org.apache.drill.exec.work.QueryWorkUnit; + +import com.google.common.collect.Lists; + +/** + * Helper class to return PlanFragments based on the query plan + * or based on split query plan + * + */ +public class PlanSplitter { + static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(PlanSplitter.class); + + private static PlanSplitter s_instance = new PlanSplitter(); + + private PlanSplitter() { + + } + + public static PlanSplitter getInstance() { + return s_instance; + } + + /** + * Method to plan the query and return list of fragments + * it will return query plan "as is" or split plans based on the req setting: split_plan + * @param dContext + * @param queryId + * @param req + * @param connection + * @return + */ + public QueryPlanFragments planFragments(DrillbitContext dContext, QueryId queryId, + GetQueryPlanFragments req, UserClientConnection connection) { + QueryPlanFragments.Builder responseBuilder = QueryPlanFragments.newBuilder(); + QueryContext queryContext = new QueryContext(connection.getSession(), dContext, queryId); + + responseBuilder.setQueryId(queryId); + + try { + responseBuilder.addAllFragments(getFragments(dContext, req, queryContext, queryId)); + responseBuilder.setStatus(QueryState.COMPLETED); + } catch (Exception e) { + final String errorMessage = String.format("Failed to produce PlanFragments for query id \"%s\" with " + + "request to %s plan", queryId, (req.getSplitPlan() ? "split" : "no split")); + DrillPBError error = DrillPBError.newBuilder().setMessage(errorMessage).setErrorType(DrillPBError.ErrorType.PLAN).build(); + + responseBuilder.setStatus(QueryState.FAILED); + responseBuilder.setError(error); + } + return responseBuilder.build(); + } + + private List<PlanFragment> getFragments(final DrillbitContext dContext, final GetQueryPlanFragments req, + final QueryContext queryContext, final QueryId queryId) throws Exception { + final PhysicalPlan plan; + final String query = req.getQuery(); + switch(req.getType()) { + case SQL: + final Pointer<String> textPlan = new Pointer<>(); + plan = DrillSqlWorker.getPlan(queryContext, query, textPlan); + break; + case PHYSICAL: + plan = dContext.getPlanReader().readPhysicalPlan(query); + break; + default: + throw new IllegalStateException("Planning fragments supports only SQL or PHYSICAL QueryType"); + } + + MemoryAllocationUtilities.setupSortMemoryAllocations(plan, queryContext); + + final PhysicalOperator rootOperator = plan.getSortedOperators(false).iterator().next(); + + final Fragment rootFragment = rootOperator.accept(MakeFragmentsVisitor.INSTANCE, null); + final SimpleParallelizer parallelizer = new SimpleParallelizerMultiPlans(queryContext); + + List<PlanFragment> fragments = Lists.newArrayList(); + + if ( req.getSplitPlan() ) { --- End diff -- I meant list of fragments based on original query and it's physical plan > Ability to submit simple type of physical plan directly to EndPoint DrillBit > for execution > ------------------------------------------------------------------------------------------ > > Key: DRILL-4132 > URL: https://issues.apache.org/jira/browse/DRILL-4132 > Project: Apache Drill > Issue Type: New Feature > Components: Execution - Flow, Execution - RPC, Query Planning & > Optimization > Reporter: Yuliya Feldman > Assignee: Yuliya Feldman > > Today Drill Query execution is optimistic and stateful (at least due to data > exchanges) - if any of the stages of query execution fails whole query fails. > If query is just simple scan, filter push down and project where no data > exchange happens between DrillBits there is no need to fail whole query when > one DrillBit fails, as minor fragments running on that DrillBit can be rerun > on the other DrillBit. There are probably multiple ways to achieve this. This > JIRA is to open discussion on: > 1. agreement that we need to support above use case > 2. means of achieving it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)