[ https://issues.apache.org/jira/browse/DRILL-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287193#comment-15287193 ]
ASF GitHub Bot commented on DRILL-4676: --------------------------------------- Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/503#discussion_r63577241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -1191,7 +1195,7 @@ public void failed(final RpcException ex) { } else { // since this won't be waited on, we can wait to deliver this event once the Foreman is ready logger.debug("Failure while sending fragment. Stopping query.", ex); - stateListener.moveToState(QueryState.FAILED, ex); --- End diff -- I just noticed the comment above, which captures what I meant: we can wait to deliver this event once the Foreman is ready. Maybe add: this case is only for leaf fragments. > Foreman.moveToState can block forever if called by the foreman thread while > the query is still being setup > ---------------------------------------------------------------------------------------------------------- > > Key: DRILL-4676 > URL: https://issues.apache.org/jira/browse/DRILL-4676 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Affects Versions: 1.6.0 > Reporter: Deneche A. Hakim > Assignee: Sudheesh Katkam > Fix For: 1.7.0 > > > When the query is being setup, foreman has a special CountDownLatch that > blocks rpc threads from delivering external events, this latch is unblocked > at the end of the query setup. > In some cases though, when the foreman is submitting remote fragments, a > failure in RpcBus.send() causes an exception to be thrown that is reported to > Foreman.FragmentSubmitListener and blocks in the CountDownLatch. This causes > the foreman thread to block forever, and can rpc threads to be blocked too. > This seems to happen more frequently at a high concurrency load, and also can > prevent clients from connecting to the Drillbits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)