[
https://issues.apache.org/jira/browse/DRILL-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290058#comment-15290058
]
ASF GitHub Bot commented on DRILL-1328:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/425#discussion_r63799606
--- Diff: exec/java-exec/src/main/codegen/data/Parser.tdd ---
@@ -36,7 +36,34 @@
"USE",
"FILES",
"REFRESH",
- "METADATA"
+ "METADATA",
+ "ANALYZE",
+ "COMPUTE",
+ "ESTIMATE",
+ "STATISTICS",
+ "COLUMNS",
+ "SAMPLE"
+ "PERCENT"
+ ]
+
+ # List of keywords from "keywords" section that are not reserved by
SQL:2003 standard.
+ # Example: "DATABASES", "TABLES" are keywords but are not reserved by
SQL:2003 standard.
+ # First keyword that starts the statement should be a reserved keyword,
otherwise the current parser
+ # ends up considering it as a expression and fails (TODO: need to follow
up with Calcite to find if it is a bug
+ # or by design.
+ nonReservedKeywords: [
+ "DATABASES",
+ "REPLACE",
+ "SCHEMAS",
+ "TABLES",
+ "FILES",
--- End diff --
Something like this came up before where a list of non reserved keyword
might result in some ambiguous queries. See
[DRILL-2116](https://issues.apache.org/jira/browse/DRILL-2116).
> Support table statistics
> ------------------------
>
> Key: DRILL-1328
> URL: https://issues.apache.org/jira/browse/DRILL-1328
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Cliff Buchanan
> Fix For: Future
>
> Attachments: 0001-PRE-Set-value-count-in-splitAndTransfer.patch
>
>
> This consists of several subtasks
> * implement operators to generate statistics
> * add "analyze table" support to parser/planner
> * create a metadata provider to allow statistics to be used by optiq in
> planning optimization
> * implement statistics functions
> Right now, the bulk of this functionality is implemented, but it hasn't been
> rigorously tested and needs to have some definite answers for some of the
> parts "around the edges" (how analyze table figures out where the table
> statistics are located, how a table "append" should work in a read only file
> system)
> Also, here are a few known caveats:
> * table statistics are collected by creating a sql query based on the string
> path of the table. This should probably be done with a Table reference.
> * Case sensitivity for column statistics is probably iffy
> * Math for combining two column NDVs into a joint NDV should be checked.
> * Schema changes aren't really being considered yet.
> * adding getDrillTable is probably unnecessary; it might be better to do
> getTable().unwrap(DrillTable.class)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
