[ https://issues.apache.org/jira/browse/DRILL-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15297222#comment-15297222 ]
ASF GitHub Bot commented on DRILL-4514: --------------------------------------- Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/436#discussion_r64299337 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java --- @@ -25,23 +25,27 @@ * - location which is a path. * - writable flag to indicate whether the location supports creating new tables. * - default storage format for new tables created in this workspace. + * - physicalLocation is full path to workspace */ @JsonIgnoreProperties(value = {"storageformat"}) public class WorkspaceConfig { /** Default workspace is a root directory which supports read, but not write. */ - public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null); + public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", false, null, null); private final String location; private final boolean writable; private final String defaultInputFormat; + private final String physicalLocation; public WorkspaceConfig(@JsonProperty("location") String location, @JsonProperty("writable") boolean writable, - @JsonProperty("defaultInputFormat") String defaultInputFormat) { + @JsonProperty("defaultInputFormat") String defaultInputFormat, + @JsonProperty("physicalLocation") String physicalLocation) { this.location = location; this.writable = writable; this.defaultInputFormat = defaultInputFormat; + this.physicalLocation = physicalLocation; --- End diff -- WorkspaceConfig already has "location". Why do you prefer adding a new "physicalLocation"? Is it possible to use "location" in stead? > Add describe schema <schema_name> command > ----------------------------------------- > > Key: DRILL-4514 > URL: https://issues.apache.org/jira/browse/DRILL-4514 > Project: Apache Drill > Issue Type: New Feature > Affects Versions: Future > Reporter: Arina Ielchiieva > Assignee: Arina Ielchiieva > > Add describe database <db_name> command which will return directory > associated with a database on the fly. > Syntax: > describe database <db_name> > describe schema <schema_name> > Output: > {noformat} > DESCRIBE SCHEMA xdf.proc; > +---------------------+----------------------------+ > | name | location | > +---------------------+----------------------------+ > | xdf.proc | maprfs://dl.data/processed | > +---------------------+----------------------------+ > {noformat} > Current implementation covers only dfs schema. > For all other "<INFORMATION UNAVAILABLE>" will be returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)