[ https://issues.apache.org/jira/browse/DRILL-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334716#comment-15334716 ]
ASF GitHub Bot commented on DRILL-4653: --------------------------------------- Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/518#discussion_r67426795 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/store/json/TestJsonRecordReader.java --- @@ -179,4 +180,43 @@ public void testNestedFilter() throws Exception { .sqlBaselineQuery(baselineQuery) .go(); } + + @Test // See DRILL-4653 +public void testSkippingInvalidJSONRecords() throws Exception { + try + { + String set = "alter session set `" + ExecConstants.JSON_READER_SKIP_INVALID_RECORDS_FLAG+ "` = true"; --- End diff -- these should be indented inside the try block with 2 spaces. It is best to set the indent level in your IDE (I can help with Eclipse if you are using it; if you are using IntelliJ I can find out from other developers using IntelliJ). > Malformed JSON should not stop the entire query from progressing > ---------------------------------------------------------------- > > Key: DRILL-4653 > URL: https://issues.apache.org/jira/browse/DRILL-4653 > Project: Apache Drill > Issue Type: Improvement > Components: Storage - JSON > Affects Versions: 1.6.0 > Reporter: subbu srinivasan > > Currently Drill query terminates upon first encounter of a invalid JSON line. > Drill has to continue progressing after ignoring the bad records. Something > similar to a setting of (ignore.malformed.json) would help. -- This message was sent by Atlassian JIRA (v6.3.4#6332)