[jira] [Commented] (DRILL-4673) Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on command return

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-4673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368647#comment-15368647
 ] 

ASF GitHub Bot commented on DRILL-4673:
---------------------------------------

Github user vdiravka commented on a diff in the pull request:

    https://github.com/apache/drill/pull/541#discussion_r70153040
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DropTableHandler.java
 ---
    @@ -69,6 +71,15 @@ public PhysicalPlan getPlan(SqlNode sqlNode) throws 
ValidationException, RelConv
               .build(logger);
         }
     
    +    final Table existingTable = 
SqlHandlerUtil.getTableFromSchema(drillSchema, tableName);
    --- End diff --
    
    I'm not sure about returning `null ` by `getTableFromSchema(...)` only if 
the table does not exist. Therefore renamed it to `tableToDrop ` and moved 
inside `if` block


> Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on 
> command return
> -------------------------------------------------------------------------------------
>
>                 Key: DRILL-4673
>                 URL: https://issues.apache.org/jira/browse/DRILL-4673
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Functions - Drill
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Minor
>              Labels: drill
>
> Implement "DROP TABLE IF EXISTS" for drill to prevent FAILED status on 
> command "DROP TABLE" return if table doesn't exist.
> The same for "DROP VIEW IF EXISTS"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)