[ 
https://issues.apache.org/jira/browse/DRILL-4530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380431#comment-15380431
 ] 

ASF GitHub Bot commented on DRILL-4530:
---------------------------------------

Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/519#discussion_r71059388
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
 ---
    @@ -212,8 +223,12 @@ public TableScan 
createTableScan(List<PartitionLocation> newPartitionLocation) t
         }
     
         if (scanRel instanceof DrillScanRel) {
    -      final FileSelection newFileSelection = new FileSelection(null, 
newFiles, getBaseTableLocation());
    -      final FileGroupScan newGroupScan = 
((FileGroupScan)((DrillScanRel)scanRel).getGroupScan()).clone(newFileSelection);
    +//      final FormatSelection formatSelection = 
(FormatSelection)((DynamicDrillTable)scanRel.getTable()).getSelection();
    +      final FormatSelection formatSelection = 
(FormatSelection)table.getSelection();
    +      final FileSelection newFileSelection = new FileSelection(null, 
newFiles, getBaseTableLocation(),
    +          cacheFileRoot, formatSelection.getSelection().getDirStatus());
    +      final FileGroupScan newGroupScan =
    +          
((FileGroupScan)((DrillScanRel)scanRel).getGroupScan()).clone(newFileSelection, 
cacheFileRoot);
    --- End diff --
    
    Fixed in commit #7ae8f7a


> Improve metadata cache performance for queries with single partition 
> ---------------------------------------------------------------------
>
>                 Key: DRILL-4530
>                 URL: https://issues.apache.org/jira/browse/DRILL-4530
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Query Planning & Optimization
>    Affects Versions: 1.6.0
>            Reporter: Aman Sinha
>            Assignee: Aman Sinha
>             Fix For: Future
>
>
> Consider two types of queries which are run with Parquet metadata caching: 
> {noformat}
> query 1:
> SELECT col FROM  `A/B/C`;
> query 2:
> SELECT col FROM `A` WHERE dir0 = 'B' AND dir1 = 'C';
> {noformat}
> For a certain dataset, the query1 elapsed time is 1 sec whereas query2 
> elapsed time is 9 sec even though both are accessing the same amount of data. 
>  The user expectation is that they should perform roughly the same.  The main 
> difference comes from reading the bigger metadata cache file at the root 
> level 'A' for query2 and then applying the partitioning filter.  query1 reads 
> a much smaller metadata cache file at the subdirectory level. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to