[ 
https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459452#comment-15459452
 ] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77403990
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
 ---
    @@ -141,25 +141,41 @@ public void validate(final OptionValue v, final 
OptionManager manager) {
     
       public static class BooleanValidator extends TypeValidator {
         public BooleanValidator(String name, boolean def) {
    -      super(name, Kind.BOOLEAN, 
OptionValue.createBoolean(OptionType.SYSTEM, name, def));
    +      this(name, def, false);
    +    }
    +
    +    public BooleanValidator(String name, boolean def, boolean 
isAdminOption) {
    +      super(name, Kind.BOOLEAN, 
OptionValue.createBoolean(OptionType.SYSTEM, name, def), isAdminOption);
         }
       }
     
       public static class StringValidator extends TypeValidator {
         public StringValidator(String name, String def) {
    -      super(name, Kind.STRING, OptionValue.createString(OptionType.SYSTEM, 
name, def));
    +      this(name, def, false);
    +    }
    +
    +    public StringValidator(String name, String def, boolean isAdminOption) 
{
    --- End diff --
    
    See above comment.


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to