[ 
https://issues.apache.org/jira/browse/DRILL-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15473379#comment-15473379
 ] 

ASF GitHub Bot commented on DRILL-4726:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/574#discussion_r77974471
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java
 ---
    @@ -179,6 +220,22 @@ public void create(final String path) {
        * @param data  data to store
        */
       public void put(final String path, final byte[] data) {
    +    put(path, data, null);
    +  }
    +
    +  /**
    +   * Puts the given byte sequence into the given path.
    +   *
    +   * If path does not exists, this call creates it.
    +   *
    +   * If version holder is not null, passes given version for comparison.
    +   * Throws {@link VersionMismatchException} if versions mismatch was 
detected.
    --- End diff --
    
    Sure, I'll add a little bit more of explanation. 
    
    Regarding UDF registration / unregistration we have 
    CreateFunctionHandler.register has try / catch clause with method recursive 
call, the same in DropFunctionHandler.unregister to ensure we write back 
version we have. If version has changed we re-validate UDFs against updated 
registry and try to update remote registry one more time till retry times 
quantity haven't been exceeded.


> Dynamic UDFs support
> --------------------
>
>                 Key: DRILL-4726
>                 URL: https://issues.apache.org/jira/browse/DRILL-4726
>             Project: Apache Drill
>          Issue Type: New Feature
>    Affects Versions: 1.6.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: Future
>
>
> Allow register UDFs without  restart of Drillbits.
> Design is described in document below:
> https://docs.google.com/document/d/1FfyJtWae5TLuyheHCfldYUpCdeIezR2RlNsrOTYyAB4/edit?usp=sharing
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to