[ 
https://issues.apache.org/jira/browse/DRILL-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15553521#comment-15553521
 ] 

ASF GitHub Bot commented on DRILL-3178:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/593#discussion_r82296690
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextInput.java
 ---
    @@ -88,6 +88,11 @@
       private boolean endFound = false;
     
       /**
    +   * Switch for enabling/disabling new line detection
    --- End diff --
    
    Explain a bit more? Presumably, we already "monitor" and "detect" new lines 
in some way. What, specifically does this add? Presumably, it sets the mode to 
enable new line detection within quotes (the title of the Jira entry)?


> csv reader should allow newlines inside quotes 
> -----------------------------------------------
>
>                 Key: DRILL-3178
>                 URL: https://issues.apache.org/jira/browse/DRILL-3178
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Storage - Text & CSV
>    Affects Versions: 1.0.0
>         Environment: Ubuntu Trusty 14.04.2 LTS
>            Reporter: Neal McBurnett
>            Assignee: F Méthot
>             Fix For: Future
>
>         Attachments: drill-3178.patch
>
>
> When reading a csv file which contains newlines within quoted strings, e.g. 
> via
>     select * from dfs.`/tmp/q.csv`;
> Drill 1.0 says:
>     Error: SYSTEM ERROR: com.univocity.parsers.common.TextParsingException:  
> Error processing input: Cannot use newline character within quoted string
> But many tools produce csv files with newlines in quoted strings.  Drill 
> should be able to handle them.
> Workaround: the csvquote program (https://github.com/dbro/csvquote) can 
> encode embedded commas and newlines, and even decode them later if desired.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to