[
https://issues.apache.org/jira/browse/DRILL-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15590193#comment-15590193
]
ASF GitHub Bot commented on DRILL-4369:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/622#discussion_r84154532
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -176,6 +181,23 @@ public void setAutoRead(boolean enableAutoRead) {
}
/**
+ * Sets the client name.
+ *
+ * If not set, default is {@code DrillClient#DEFAULT_CLIENT_NAME}.
+ *
+ * @param name the client name
+ *
+ * @throws IllegalStateException if called after a connection has been
established.
+ * @throws NullPointerException if client name is null
--- End diff --
Old clients won't know to provide a name. The name will thus be null. But,
we throw an NPE in this case. Two issues.
First, is an NPE the right way to communicate to a (new) client that it
failed to follow the (now required) protocol? Should this be translated to some
kind of protocol exception somewhere? If so, how will we know that this is an
NPE from a protocol error vs just a code bug?
Second, where do we handle the case that a client does not provide a name?
There should be a reasonable default (which seems to be the default name, but
this bit is no exactly clear.)
> Database driver fails to report any major or minor version information
> ----------------------------------------------------------------------
>
> Key: DRILL-4369
> URL: https://issues.apache.org/jira/browse/DRILL-4369
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.4.0
> Reporter: N Campbell
>
> Using Apache 1.4 Drill
> The DatabaseMetadata.getters to obtain the Major and Minor versions of the
> server or JDBC driver return 0 instead of 1.4.
> This prevents an application from dynamically adjusting how it interacts
> based on which version of Drill a connection is accessing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
