[ https://issues.apache.org/jira/browse/DRILL-4674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15607107#comment-15607107 ]
ASF GitHub Bot commented on DRILL-4674: --------------------------------------- Github user gparai commented on a diff in the pull request: https://github.com/apache/drill/pull/610#discussion_r85036776 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/BooleanType.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.expr.fn.impl; + +import java.util.Arrays; +import java.util.List; + +/** + * Enum that contains two boolean types: TRUE and FALSE. + * Each has numeric representation and list of allowed literals. + * List of literals is formed according to + * {@link <a href="https://www.postgresql.org/docs/9.6/static/datatype-boolean.html">Postgre Documentation</a>} + */ +public enum BooleanType { + TRUE(1, Arrays.asList("t", "true", "y", "yes", "on", "1")), + FALSE(0, Arrays.asList("f", "false", "n", "no", "off", "0")); + + private int numericValue; + private List<String> literals; + + BooleanType(int numericValue, List<String> literals) { + this.numericValue = numericValue; + this.literals = literals; + } + + public int getNumericValue() { + return numericValue; --- End diff -- Please correct alignment here and in getLiterals() > Allow casting to boolean the same literals as in Postgre > -------------------------------------------------------- > > Key: DRILL-4674 > URL: https://issues.apache.org/jira/browse/DRILL-4674 > Project: Apache Drill > Issue Type: Improvement > Components: Execution - Data Types > Affects Versions: 1.7.0 > Environment: 4 node cluster CentOS > Reporter: Khurram Faraaz > Assignee: Gautam Kumar Parai > Labels: doc-impacting > Fix For: 1.9.0 > > > Drill does not return results when we try to cast 0 and 1 to boolean inside a > value constructor. > Drill version : 1.7.0-SNAPSHOT commit ID : 09b26277 > {noformat} > 0: jdbc:drill:schema=dfs.tmp> values(cast(1 as boolean)); > Error: SYSTEM ERROR: IllegalArgumentException: Invalid value for boolean: 1 > Fragment 0:0 > [Error Id: 35dcc4bb-0c5d-466f-8fb5-cf7f0a892155 on centos-02.qa.lab:31010] > (state=,code=0) > 0: jdbc:drill:schema=dfs.tmp> values(cast(0 as boolean)); > Error: SYSTEM ERROR: IllegalArgumentException: Invalid value for boolean: 0 > Fragment 0:0 > [Error Id: 2dbcafe2-92c7-475e-a2aa-9745ef72c1cc on centos-02.qa.lab:31010] > (state=,code=0) > {noformat} > Where as we get results on Postgres for same query. > {noformat} > postgres=# values(cast(1 as boolean)); > column1 > --------- > t > (1 row) > postgres=# values(cast(0 as boolean)); > column1 > --------- > f > (1 row) > {noformat} > Stack trace from drillbit.log > {noformat} > 2016-05-13 07:16:16,578 [28ca80bf-0af9-bc05-258b-6b5744739ed8:frag:0:0] ERROR > o.a.d.e.w.fragment.FragmentExecutor - SYSTEM ERROR: IllegalArgumentException: > Invalid value for boolean: 0 > Fragment 0:0 > [Error Id: 2dbcafe2-92c7-475e-a2aa-9745ef72c1cc on centos-02.qa.lab:31010] > org.apache.drill.common.exceptions.UserException: SYSTEM ERROR: > IllegalArgumentException: Invalid value for boolean: 0 > Fragment 0:0 > [Error Id: 2dbcafe2-92c7-475e-a2aa-9745ef72c1cc on centos-02.qa.lab:31010] > at > org.apache.drill.common.exceptions.UserException$Builder.build(UserException.java:543) > ~[drill-common-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.sendFinalState(FragmentExecutor.java:318) > [drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:185) > [drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:287) > [drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38) > [drill-common-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > [na:1.7.0_45] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > [na:1.7.0_45] > at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45] > Caused by: java.lang.IllegalArgumentException: Invalid value for boolean: 0 > at > org.apache.drill.exec.test.generated.ProjectorGen9.doSetup(ProjectorTemplate.java:95) > ~[na:na] > at > org.apache.drill.exec.test.generated.ProjectorGen9.setup(ProjectorTemplate.java:93) > ~[na:na] > at > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.setupNewSchema(ProjectRecordBatch.java:444) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:78) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext(ProjectRecordBatch.java:129) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:162) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:104) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext(ScreenCreator.java:81) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:94) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.work.fragment.FragmentExecutor$1.run(FragmentExecutor.java:257) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at > org.apache.drill.exec.work.fragment.FragmentExecutor$1.run(FragmentExecutor.java:251) > ~[drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > at java.security.AccessController.doPrivileged(Native Method) > ~[na:1.7.0_45] > at javax.security.auth.Subject.doAs(Subject.java:415) ~[na:1.7.0_45] > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1595) > ~[hadoop-common-2.7.0-mapr-1602.jar:na] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:251) > [drill-java-exec-1.7.0-SNAPSHOT.jar:1.7.0-SNAPSHOT] > ... 4 common frames omitted > {noformat} > Implementation: > Will be added support to allow casting the same list of strings as in > Postgres [https://www.postgresql.org/docs/9.6/static/datatype-boolean.html] -- This message was sent by Atlassian JIRA (v6.3.4#6332)