[
https://issues.apache.org/jira/browse/DRILL-4974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613677#comment-15613677
]
ASF GitHub Bot commented on DRILL-4974:
---------------------------------------
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/634
DRILL-4974: NPE in FindPartitionConditions.analyzeCall() for 'holistic'
expressions
Changes: Added a missing null check in
FindPartitionConditions.analyzeCall(), to ensure that opStack.peek() value is
dereferenced only after a null-check. Without this check, if the expression is
holistic, opStack can be null, so using the value of opStack.peek() without a
check can cause an NPE.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bitblender/drill DRILL-4974
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #634
----
commit a519a0987280abeb00e33a8088d2f7d6c9809eed
Author: karthik <kmanivan...@maprtech.com>
Date: 2016-10-20T20:43:17Z
DRILL-4974: Add missing null check in FindPartitionConditions.analyzeCall()
----
> NPE in FindPartitionConditions.analyzeCall() for 'holistic' expressions
> -----------------------------------------------------------------------
>
> Key: DRILL-4974
> URL: https://issues.apache.org/jira/browse/DRILL-4974
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Relational Operators
> Affects Versions: 1.6.0, 1.7.0, 1.8.0
> Reporter: Karthikeyan Manivannan
> Assignee: Karthikeyan Manivannan
> Fix For: 1.8.0
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> The following query can cause an NPE in FindPartitionConditions.analyzeCall()
> if the fileSize column is a partitioned column.
> SELECT fileSize FROM dfs.`/drill-data/data/` WHERE compoundId LIKE
> 'FOO-1234567%'
> This is because, the LIKE is treated as a holistic expression in
> FindPartitionConditions.analyzeCall(), causing opStack to be empty, thus
> causing opStack.peek() to return a NULL value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
