[ https://issues.apache.org/jira/browse/DRILL-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15780406#comment-15780406 ]
ASF GitHub Bot commented on DRILL-5039: --------------------------------------- GitHub user arina-ielchiieva opened a pull request: https://github.com/apache/drill/pull/706 DRILL-5039: NPE - CTAS PARTITION BY (<char-type-column>) 1. Moved varchar `newPartitionValue` functions to `NewValueFunctions` template: a. took advantage of code generation for varchar `newPartitionValue` functions; b. all `newPartitionValue` functions will be in one file. 2. Fixed logic for reassigning nullable varchar holders during `newPartitionValue` function execution (previously resulted in NPE if varchar partition column contained nulls). 3. Added `alltypes_optional.parquet` (each type contains at least one null value) in test resources and updated `alltypes_required.parquet` to have the same types as in `alltypes_optional.parquet`. 4. Added new unit test `testPartitionByForAllTypes` to cover all types and cases (with and without nulls) during CTAS with partitioning. 5. Updated `minMaxEmptyNonNullableInput` test to reflect changes in `alltypes_required.parquet`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arina-ielchiieva/drill DRILL-5039 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/706.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #706 ---- commit 3521339a8a39dc8cef5b769ee8abce00e6a88ba7 Author: Arina Ielchiieva <arina.yelchiy...@gmail.com> Date: 2016-12-23T17:51:38Z DRILL-5039: NPE - CTAS PARTITION BY (<char-type-column>) ---- > NPE - CTAS PARTITION BY (<char-type-column>) > -------------------------------------------- > > Key: DRILL-5039 > URL: https://issues.apache.org/jira/browse/DRILL-5039 > Project: Apache Drill > Issue Type: Bug > Components: Execution - Flow > Affects Versions: 1.9.0 > Reporter: Khurram Faraaz > Assignee: Arina Ielchiieva > Priority: Critical > Fix For: Future > > > We are seeing an NPE, when CTAS is used with PARTITION BY > (<char-type-column>) and all columns are projected in SELECT of CTAS. > Drill 1.9.0 > git commit ID : db30854 > {noformat} > 0: jdbc:drill:schema=dfs.tmp> CREATE TABLE dfs.tmp.temp_tbl > . . . . . . . . . . . . . . > PARTITION BY (col_chr) > . . . . . . . . . . . . . . > AS > . . . . . . . . . . . . . . > SELECT col_int, col_chr, col_vrchr1, col_vrchr2 > , col_dt, col_tim, col_tmstmp , col_flt, col_intrvl_yr , col_intrvl_day , > col_bln > . . . . . . . . . . . . . . > FROM typeall_l; > Error: SYSTEM ERROR: NullPointerException > Fragment 0:0 > [Error Id: ab6c199e-cb61-42dd-ae22-0090eea22ec5 on centos-01.qa.lab:31010] > (state=,code=0) > {noformat} > {noformat} > 2016-11-12 19:54:14,901 [27d88c99-a64d-0317-ba3b-d78195cf85cc:frag:0:0] ERROR > o.a.d.e.w.fragment.FragmentExecutor - SYSTEM ERROR: NullPointerException > Fragment 0:0 > [Error Id: ab6c199e-cb61-42dd-ae22-0090eea22ec5 on centos-01.qa.lab:31010] > org.apache.drill.common.exceptions.UserException: SYSTEM ERROR: > NullPointerException > Fragment 0:0 > [Error Id: ab6c199e-cb61-42dd-ae22-0090eea22ec5 on centos-01.qa.lab:31010] > at > org.apache.drill.common.exceptions.UserException$Builder.build(UserException.java:543) > ~[drill-common-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.sendFinalState(FragmentExecutor.java:293) > [drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:160) > [drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:262) > [drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38) > [drill-common-1.9.0.jar:1.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > [na:1.8.0_91] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > [na:1.8.0_91] > at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91] > Caused by: java.lang.NullPointerException: null > at > org.apache.drill.exec.expr.fn.impl.ByteFunctionHelpers.compare(ByteFunctionHelpers.java:100) > ~[vector-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.test.generated.ProjectorGen3.doEval(ProjectorTemplate.java:88) > ~[na:na] > at > org.apache.drill.exec.test.generated.ProjectorGen3.projectRecords(ProjectorTemplate.java:62) > ~[na:na] > at > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.doWork(ProjectRecordBatch.java:199) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:93) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext(ProjectRecordBatch.java:135) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:162) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:119) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:109) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.WriterRecordBatch.innerNext(WriterRecordBatch.java:91) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:162) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:119) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:109) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext(AbstractSingleRecordBatch.java:51) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext(ProjectRecordBatch.java:135) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.record.AbstractRecordBatch.next(AbstractRecordBatch.java:162) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:104) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext(ScreenCreator.java:81) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.physical.impl.BaseRootExec.next(BaseRootExec.java:94) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.work.fragment.FragmentExecutor$1.run(FragmentExecutor.java:232) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at > org.apache.drill.exec.work.fragment.FragmentExecutor$1.run(FragmentExecutor.java:226) > ~[drill-java-exec-1.9.0.jar:1.9.0] > at java.security.AccessController.doPrivileged(Native Method) > ~[na:1.8.0_91] > at javax.security.auth.Subject.doAs(Subject.java:422) ~[na:1.8.0_91] > at > org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657) > ~[hadoop-common-2.7.1.jar:na] > at > org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:226) > [drill-java-exec-1.9.0.jar:1.9.0] > ... 4 common frames omitted > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)