[ 
https://issues.apache.org/jira/browse/DRILL-5172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15816338#comment-15816338
 ] 

ASF GitHub Bot commented on DRILL-5172:
---------------------------------------

Github user kkhatua commented on a diff in the pull request:

    https://github.com/apache/drill/pull/719#discussion_r95469066
  
    --- Diff: 
protocol/src/main/java/org/apache/drill/exec/proto/UserBitShared.java ---
    @@ -13595,6 +13597,17 @@ public long getEnd() {
           return end_;
         }
     
    +    public String getDuration() {
    --- End diff --
    
    The ProfileInfo class is actually where the change was made to retrieve the 
value from the model. We don't create any duration field, as it is computed 
based on the other 2 fields (start,end) and simply provide a getter for that. 
However, the ProfileInfo class is used only by the profiles listing freemarker 
template (list.ftl). 
    For the individual query profile's template (profile.ftl), the model from 
which we retrieve the duration value is auto-generated by the protobuf, making 
this a lot more complicated to implement. Hence, we took the JavaScript 
approach. 
    I'll probably refine it to strictly follow the MVC model when I'm 
attempting a fix for DRILL-5190 
https://issues.apache.org/jira/browse/DRILL-5190  [Display planning time for a 
query in its profile page ] , since that would require me to modify the 
protobuf.


> Display elapsed time for queries in the UI
> ------------------------------------------
>
>                 Key: DRILL-5172
>                 URL: https://issues.apache.org/jira/browse/DRILL-5172
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components: Web Server
>    Affects Versions: 1.9.0
>            Reporter: Kunal Khatua
>            Assignee: Kunal Khatua
>            Priority: Minor
>             Fix For: 1.10.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, the Web UI does not display the runtime for a query either in the 
> list of queries or the query profile page itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to