[ https://issues.apache.org/jira/browse/DRILL-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878968#comment-15878968 ]
ASF GitHub Bot commented on DRILL-5257: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/747#discussion_r102541268 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java --- @@ -178,6 +182,19 @@ public Foreman(final WorkerBee bee, final DrillbitContext drillbitContext, final QueryState initialState = queuingEnabled ? QueryState.ENQUEUED : QueryState.STARTING; recordNewState(initialState); enqueuedQueries.inc(); + + profileOption = setProfileOption(queryContext.getOptions()); + } + + private ProfileOption setProfileOption(OptionManager options) { + if (! options.getOption(ExecConstants.ENABLE_QUERY_PROFILE_VALIDATOR)) { --- End diff -- I believe we do allow spacing around operators: a - b instead of a-b, etc. > Provide option to save query profiles sync, async or not at all > --------------------------------------------------------------- > > Key: DRILL-5257 > URL: https://issues.apache.org/jira/browse/DRILL-5257 > Project: Apache Drill > Issue Type: Improvement > Affects Versions: 1.10 > Reporter: Paul Rogers > Assignee: Paul Rogers > Priority: Minor > Fix For: 1.10 > > > DRILL-5123 improved perceived query performance by writing the query profile > after sending a final response to the client. This is the desired behaviors > in most situations. However, some tests want to verify certain results by > reading the query profile from disk. Doing so works best when the query > profile is written before returning the final query results. > This ticket requests that the timing if the query profile writing be > configurable. > * Sync: write profile before final client response. > * Async: write profile after final client response. (Default) > * None: don't write query profile at all > A config option (boot time? run time?) should control the option. A boot-time > option is fine for testing. -- This message was sent by Atlassian JIRA (v6.3.15#6346)