[ https://issues.apache.org/jira/browse/DRILL-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883478#comment-15883478 ]
ASF GitHub Bot commented on DRILL-5195: --------------------------------------- Github user kkhatua commented on a diff in the pull request: https://github.com/apache/drill/pull/756#discussion_r103028895 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/FragmentWrapper.java --- @@ -136,26 +240,60 @@ public String getContent() { biggestBatches = Math.max(biggestBatches, batches); } - builder.appendCell(new OperatorPathBuilder().setMajor(major).setMinor(minor).build(), null); - builder.appendCell(minor.getEndpoint().getAddress(), null); - builder.appendMillis(minor.getStartTime() - start, null); - builder.appendMillis(minor.getEndTime() - start, null); - builder.appendMillis(minor.getEndTime() - minor.getStartTime(), null); + builder.appendCell(new OperatorPathBuilder().setMajor(major).setMinor(minor).build()); + builder.appendCell(minor.getEndpoint().getAddress()); + builder.appendMillis(minor.getStartTime() - start); + builder.appendMillis(minor.getEndTime() - start); + builder.appendMillis(minor.getEndTime() - minor.getStartTime()); - builder.appendFormattedInteger(biggestIncomingRecords, null); - builder.appendFormattedInteger(biggestBatches, null); + builder.appendFormattedInteger(biggestIncomingRecords); + builder.appendFormattedInteger(biggestBatches); - builder.appendTime(minor.getLastUpdate(), null); - builder.appendTime(minor.getLastProgress(), null); + builder.appendTime(minor.getLastUpdate()); + builder.appendTime(minor.getLastProgress()); - builder.appendBytes(minor.getMaxMemoryUsed(), null); - builder.appendCell(minor.getState().name(), null); + builder.appendBytes(minor.getMaxMemoryUsed()); + builder.appendCell(minor.getState().name()); } for (final MinorFragmentProfile m : incomplete) { - builder.appendCell(major.getMajorFragmentId() + "-" + m.getMinorFragmentId(), null); + builder.appendCell(major.getMajorFragmentId() + "-" + m.getMinorFragmentId()); builder.appendRepeated(m.getState().toString(), null, NUM_NULLABLE_FRAGMENTS_COLUMNS); } return builder.build(); } + + private class OverviewTblTxt { + static final String MajorFragment = "Major Fragment"; + static final String MinorFragmentsReporting = "Minor Fragments Reporting"; + static final String FirstStart = "First Start"; + static final String LastStart = "Last Start"; + static final String FirstEnd = "First End"; + static final String LastEnd = "Last End"; + static final String MinRuntime = "Min Runtime"; + static final String AvgRuntime = "Avg Runtime"; + static final String MaxRuntime = "Max Runtime"; + static final String PercentBusy = "% Busy"; + static final String LastUpdate = "Last Update"; + static final String LastProgress = "Last Progress"; + static final String MaxPeakMemory = "Max Peak Memory"; + } + + private class OverviewTblTooltip { + static final String MajorFragment = "Major Fragment ID"; + static final String MinorFragmentsReporting = "Number of Minor Fragments Spawned"; + static final String FirstStart = "Earliest start of a fragment since query submission"; + static final String LastStart = "Latest start of a fragment since query submission"; + static final String FirstEnd = "Earliest completion time a fragment"; --- End diff -- +1 Applied changes to all. > Publish Operator and MajorFragment Stats in Profile page > -------------------------------------------------------- > > Key: DRILL-5195 > URL: https://issues.apache.org/jira/browse/DRILL-5195 > Project: Apache Drill > Issue Type: Improvement > Components: Web Server > Affects Versions: 1.9.0 > Reporter: Kunal Khatua > Assignee: Kunal Khatua > Attachments: dbit_complete.png, dbit_inflight.png, dbit_opOverview.png > > > Currently, we show runtimes for major fragments, and min,max,avg times for > setup, processing and waiting for various operators. > It would be worthwhile to have additional stats for the following: > MajorFragment > %Busy - % of the active time for all the minor fragments within each major > fragment that they were busy. > Operator Profile > %Busy - % of the active time for all the fragments within each operator > that they were busy. > Records - Total number of records propagated out by that operator. -- This message was sent by Atlassian JIRA (v6.3.15#6346)