[ 
https://issues.apache.org/jira/browse/DRILL-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15887793#comment-15887793
 ] 

ASF GitHub Bot commented on DRILL-5301:
---------------------------------------

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/764#discussion_r103426496
  
    --- Diff: protocol/src/main/protobuf/User.proto ---
    @@ -439,6 +439,211 @@ message CreatePreparedStatementResp {
     }
     
     /*
    + * Request message for getting server metadata
    + */
    +message GetServerMetaReq {
    +}
    +
    +enum CollateSupport {
    --- End diff --
    
    For all enums below, use UNKNOWN as the zero-th value to avoid the problem 
[mentioned 
here](http://androiddevblog.com/protocol-buffers-pitfall-adding-enum-values/)?


> Add server metadata API
> -----------------------
>
>                 Key: DRILL-5301
>                 URL: https://issues.apache.org/jira/browse/DRILL-5301
>             Project: Apache Drill
>          Issue Type: Improvement
>          Components:  Server, Client - C++, Client - Java, Client - JDBC, 
> Client - ODBC
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>
> JDBC and ODBC clients exposes lots of metadata regarding server version and 
> support of various parts of the SQL standard.
> Currently the returned information is hardcoded in both clients/drivers which 
> means that the infomation returned is support as of the client version, not 
> the server version.
> Instead, a new method should be provided to the clients to query the actual 
> server support. Support on the client or the server should be optional (for 
> example a client should not use this API if the server doesn't support it and 
> fallback to default values).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to