[
https://issues.apache.org/jira/browse/DRILL-5165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901960#comment-15901960
]
ASF GitHub Bot commented on DRILL-5165:
---------------------------------------
Github user chunhui-shi commented on the issue:
https://github.com/apache/drill/pull/776
It failed without the fix.
________________________________
From: Jinfeng Ni <[email protected]>
Sent: Wednesday, March 8, 2017 10:56:06 AM
To: apache/drill
Cc: Chunhui Shi; Author
Subject: Re: [apache/drill] DRILL-5165: limitRel to return correct rows for
limit all case (#776)
@jinfengni commented on this pull request.
________________________________
In
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/limit/TestLimitWithExchanges.java<https://github.com/apache/drill/pull/776#discussion_r104993761>:
> @@ -125,6 +125,15 @@ public void testLimitImpactExchange() throws
Exception {
}
}
+ @Test
+ public void TestLimitAllOnParquet() throws Exception {
Have you tried this new testcase without the change above? Will it
successful or fail?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/drill/pull/776#pullrequestreview-25853026>, or
mute the
thread<https://github.com/notifications/unsubscribe-auth/AJa9A-HOKR8SCsdrPSb_457T4kbuelsBks5rjvnGgaJpZM4MWjjd>.
> wrong results - LIMIT ALL and OFFSET clause in same query
> ---------------------------------------------------------
>
> Key: DRILL-5165
> URL: https://issues.apache.org/jira/browse/DRILL-5165
> Project: Apache Drill
> Issue Type: Bug
> Components: Query Planning & Optimization
> Affects Versions: 1.10.0
> Reporter: Khurram Faraaz
> Assignee: Chunhui Shi
> Priority: Critical
>
> This issue was reported by a user on Drill's user list.
> Drill 1.10.0 commit ID : bbcf4b76
> I tried a similar query on apache Drill 1.10.0 and Drill returns wrong
> results when compared to Postgres, for a query that uses LIMIT ALL and OFFSET
> clause in the same query. We need to file a JIRA to track this issue.
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> select col_int from typeall_l order by 1 limit
> all offset 10;
> +----------+
> | col_int |
> +----------+
> +----------+
> No rows selected (0.211 seconds)
> 0: jdbc:drill:schema=dfs.tmp> select col_int from typeall_l order by col_int
> limit all offset 10;
> +----------+
> | col_int |
> +----------+
> +----------+
> No rows selected (0.24 seconds)
> {noformat}
> Query => select col_int from typeall_l limit all offset 10;
> Drill 1.10.0 returns 85 rows
> whereas for same query,
> postgres=# select col_int from typeall_l limit all offset 10;
> Postgres 9.3 returns 95 rows, which is the correct expected result.
> Query plan for above query that returns wrong results
> {noformat}
> 0: jdbc:drill:schema=dfs.tmp> explain plan for select col_int from typeall_l
> limit all offset 10;
> +------+------+
> | text | json |
> +------+------+
> | 00-00 Screen
> 00-01 Project(col_int=[$0])
> 00-02 SelectionVectorRemover
> 00-03 Limit(offset=[10])
> 00-04 Scan(groupscan=[ParquetGroupScan [entries=[ReadEntryWithPath
> [path=maprfs:///tmp/typeall_l]], selectionRoot=maprfs:/tmp/typeall_l,
> numFiles=1, usedMetadataFile=false, columns=[`col_int`]]])
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
