[ https://issues.apache.org/jira/browse/DRILL-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928297#comment-15928297 ]
ASF GitHub Bot commented on DRILL-3510: --------------------------------------- Github user vdiravka commented on a diff in the pull request: https://github.com/apache/drill/pull/520#discussion_r106453245 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillDatabaseMetaDataImpl.java --- @@ -184,6 +184,17 @@ private ServerMeta getServerMeta() throws SQLException { return serverMeta; } + /** + * The same as {@link DrillDatabaseMetaDataImpl#getServerMeta()} but updates server metadata for the every call + * @return server meta information + * @throws SQLException for error when getting server meta + */ + private ServerMeta getUpdatedServerMeta() throws SQLException { --- End diff -- You are right regarding SQLServer JDBC metadata. Eventually I think for now we can left `getIdentifierQuoteString()` without updating for every call until it will be really necessary to handle direct session changes in DatabaseMetadata. > Add ANSI_QUOTES option so that Drill's SQL Parser will recognize ANSI_SQL > identifiers > -------------------------------------------------------------------------------------- > > Key: DRILL-3510 > URL: https://issues.apache.org/jira/browse/DRILL-3510 > Project: Apache Drill > Issue Type: Improvement > Components: SQL Parser > Reporter: Jinfeng Ni > Assignee: Vitalii Diravka > Labels: doc-impacting > Fix For: 1.10.0 > > Attachments: DRILL-3510.patch, DRILL-3510.patch > > > Currently Drill's SQL parser uses backtick as identifier quotes, the same as > what MySQL does. However, this is different from ANSI SQL specification, > where double quote is used as identifier quotes. > MySQL has an option "ANSI_QUOTES", which could be switched on/off by user. > Drill should follow the same way, so that Drill users do not have to rewrite > their existing queries, if their queries use double quotes. > {code} > SET sql_mode='ANSI_QUOTES'; > {code} > -- This message was sent by Atlassian JIRA (v6.3.15#6346)