[
https://issues.apache.org/jira/browse/DRILL-5319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957593#comment-15957593
]
ASF GitHub Bot commented on DRILL-5319:
---------------------------------------
Github user gparai commented on a diff in the pull request:
https://github.com/apache/drill/pull/787#discussion_r109986447
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
---
@@ -90,19 +90,19 @@ public void validate(final OptionValue v, final
OptionManager manager) {
}
public static class MinRangeDoubleValidator extends RangeDoubleValidator
{
- private final double min;
- private final double max;
+// private final double min;
--- End diff --
Please remove the comments here and below
> Refactor FragmentContext and OptionManager for unit testing
> -----------------------------------------------------------
>
> Key: DRILL-5319
> URL: https://issues.apache.org/jira/browse/DRILL-5319
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Tools, Build & Test
> Affects Versions: 1.10.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.11.0
>
>
> Roll-up task for two refactorings, see the sub-tasks for details. This ticket
> allows a single PR for the two different refactorings since the work heavily
> overlaps. See DRILL-5320 and DRILL-5321 for details.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
