[
https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957878#comment-15957878
]
ASF GitHub Bot commented on DRILL-4335:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r109971454
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/AbstractRemoteConnection.java
---
@@ -34,16 +37,26 @@
private final WriteManager writeManager;
private final RequestIdMap requestIdMap = new RequestIdMap();
private final String clientName;
-
private String name;
+ // Encryption related parameters
+ private EncryptionContext encryptionContext;
+ // SaslBackendWrapper to hold instance of SaslClient/SaslServer
+ protected SaslBackendWrapper saslBackend;
+
public AbstractRemoteConnection(SocketChannel channel, String name) {
this.channel = channel;
this.clientName = name;
this.writeManager = new WriteManager();
+ this.encryptionContext = new EncryptionContext();
channel.pipeline().addLast(new BackPressureHandler());
}
+ public AbstractRemoteConnection(SocketChannel channel, String name,
EncryptionContext encryptionContext) {
+ this(channel, name);
+ this.encryptionContext.initialize(encryptionContext);
--- End diff --
To avoid `initialize`, call this ctor from the other one and move other
inits here.
> Apache Drill should support network encryption
> ----------------------------------------------
>
> Key: DRILL-4335
> URL: https://issues.apache.org/jira/browse/DRILL-4335
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Keys Botzum
> Assignee: Sorabh Hamirwasia
> Labels: security
> Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this
> needs to include network level encryption and not just authentication. This
> is particularly important for the client connection to Drill which will often
> be sending passwords in the clear until there is encryption.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
