[
https://issues.apache.org/jira/browse/DRILL-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15984071#comment-15984071
]
ASF GitHub Bot commented on DRILL-4335:
---------------------------------------
Github user sudheeshkatkam commented on a diff in the pull request:
https://github.com/apache/drill/pull/773#discussion_r113353207
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/RpcConstants.java ---
@@ -24,4 +24,29 @@ private RpcConstants(){}
public static final boolean SOME_DEBUGGING = false;
public static final boolean EXTRA_DEBUGGING = false;
+
+ // RPC Handler names
+ public static final String TIMEOUT_HANDLER = "timeout-handler";
+ public static final String PROTOCOL_DECODER = "protocol-decoder";
+ public static final String PROTOCOL_ENCODER = "protocol-encoder";
+ public static final String MESSAGE_DECODER = "message-decoder";
+ public static final String HANDSHAKE_HANDLER = "handshake-handler";
+ public static final String MESSAGE_HANDLER = "message-handler";
+ public static final String EXCEPTION_HANDLER = "exception-handler";
+ public static final String IDLE_STATE_HANDLER = "idle-state-handler";
+ public static final String SASL_DECRYPTION_HANDLER =
"sasldecryption-handler";
+ public static final String SASL_ENCRYPTION_HANDLER =
"saslencryption-handler";
+ public static final String LENGTH_DECODER_HANDLER = "length-decoder";
+ public static final String CHUNK_CREATION_HANDLER =
"chunkcreation-handler";
+
+
+
+ // SASL RFC 2222/4422 allows only 3 octets to specify the length of
maximum encoded buffer each side can receive.
+ // Hence the maximum buffer size is capped at 16Mb i.e. 0XFFFFFF bytes.
+ public static final int MAX_WRAPPED_SIZE = 0XFFFFFF;
+
+ public static final int LENGTH_FIELD_OFFSET = 0;
+ public static final int LENGTH_FIELD_LENGTH = 4;
--- End diff --
Better name for `LENGTH_FIELD_LENGTH`?
> Apache Drill should support network encryption
> ----------------------------------------------
>
> Key: DRILL-4335
> URL: https://issues.apache.org/jira/browse/DRILL-4335
> Project: Apache Drill
> Issue Type: New Feature
> Reporter: Keys Botzum
> Assignee: Sorabh Hamirwasia
> Labels: security
> Attachments: ApacheDrillEncryptionUsingSASLDesign.pdf
>
>
> This is clearly related to Drill-291 but wanted to make explicit that this
> needs to include network level encryption and not just authentication. This
> is particularly important for the client connection to Drill which will often
> be sending passwords in the clear until there is encryption.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
