[
https://issues.apache.org/jira/browse/DRILL-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992351#comment-15992351
]
ASF GitHub Bot commented on DRILL-5450:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/821#discussion_r114249334
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
---
@@ -308,4 +308,58 @@ public void testReverseLongVarChars() throws Exception
{
FileUtils.deleteQuietly(path);
}
}
+
+ @Test
+ public void testLower() throws Exception {
+ testBuilder()
+ .sqlQuery("select\n" +
+ "lower('ABC') col_upper,\n" +
+ "lower('abc') col_lower,\n" +
--- End diff --
Please add tests for Greek and Cyrillic. Our source encoding is UTF-8, so
you can enter the characters directly. Or, if that does not work, you can
instead use the Java Unicode encoding: U1234.
If the tests fail because of parsing of SQL, please file a bug. If they
fail because the function above does not support UTF-8, please file a different
bug.
In either case, you can then comment out the test cases and add a comment
that says that they fail due to DRILL-xxxx, whatever your bug number turns out
to be.
> Fix initcap function to convert upper case characters correctly
> ---------------------------------------------------------------
>
> Key: DRILL-5450
> URL: https://issues.apache.org/jira/browse/DRILL-5450
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
> Affects Versions: 1.10.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
>
> Initcap function converts incorrectly subsequent upper case characters after
> first character.
> {noformat}
> 0: jdbc:drill:zk=local> select initcap('aaa') from (values(1));
> +---------+
> | EXPR$0 |
> +---------+
> | Aaa |
> +---------+
> 1 row selected (0.275 seconds)
> 0: jdbc:drill:zk=local> select initcap('AAA') from (values(1));
> +---------+
> | EXPR$0 |
> +---------+
> | A!! |
> +---------+
> 1 row selected (0.27 seconds)
> 0: jdbc:drill:zk=local> select initcap('aAa') from (values(1));
> +---------+
> | EXPR$0 |
> +---------+
> | A!a |
> +---------+
> 1 row selected (0.229 seconds)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
