[
https://issues.apache.org/jira/browse/DRILL-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075355#comment-16075355
]
ASF GitHub Bot commented on DRILL-5547:
---------------------------------------
GitHub user dvjyothsna opened a pull request:
https://github.com/apache/drill/pull/868
Drill5547
FIXED CONFIG LINKAGE - DRILL-5547
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dvjyothsna/drill DRILL5547
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/868.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #868
----
commit 068cb13eba6c95ba873b9e6d8384b13dba1eb8a2
Author: Jyothsna Donapati <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-07T18:15:08Z
Testing config linkage
commit d76e1c619720fe48e127a8fd1b8635ad0a99eef0
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-16T18:07:25Z
Added config linkage
commit c13fe5e87497679d242d2abac6c7c36488af2dd0
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-21T17:08:28Z
Added new query result structure
commit 5333a9da00e4dafd8ec227af18597212bf95349c
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-21T17:36:06Z
Added comments
commit df5ba751c5565cf3accdaa4104c35c24365ae2b8
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-26T17:47:08Z
Added comments
commit 9bba102fe91d5871e042bc75e23395d62372ae69
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-28T22:25:30Z
modified extended option iterator
commit ca2c071abd3b626e4ac3cbf3eaff7cbf524acf13
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-29T05:10:18Z
Modified default to system
commit f485043bce0238b9c0ee907c48392cd50946b97f
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-30T16:51:59Z
modified test cases
commit e40d42116ebd2e7a6cfcb36c77cd63c0a145091f
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-30T17:27:28Z
Modified test cases
commit 45ee2ad944a7a9892ac206ad5e11f8c77362a19f
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-06-30T18:05:52Z
removed old test
commit 555640df8c75b7f4d63678b44671e56040bd003e
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-04T10:38:47Z
Modified sys opt manager
commit b0a7b78fe63c73e0bbbc3c3c5a5becdefff8387c
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-04T10:46:38Z
Merge remote-tracking branch 'upstream/master' into DRILL-5547
Merge with upstream
commit 1386a8d4a61147a2fe0726676e81b0f3e68f7c17
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-04T16:28:56Z
added new validator
commit 9ae7803314652ceab5771c732cbd5c83fb13f25d
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-05T18:05:33Z
Modified option iterator
commit 06198a9d4224b240213e883baa1e2d686696c3d4
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-05T20:17:35Z
formatting done
commit 08844403dbb9a7b2c32ce6e723e5c6024db67009
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-05T20:20:33Z
Formatted code
commit 896dce74f7dc6467e7a421e4f42ab85adab99fa2
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-05T20:22:06Z
formatted code
commit 91b0fb03cbf25aef490ef7dd5eb7e6ab2c557595
Author: dvjyothsna <jyothsnadonapati@skatkam-598.local>
Date: 2017-07-05T20:24:00Z
Format
----
> Drill config options and session options do not work as intended
> ----------------------------------------------------------------
>
> Key: DRILL-5547
> URL: https://issues.apache.org/jira/browse/DRILL-5547
> Project: Apache Drill
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.10.0
> Reporter: Karthikeyan Manivannan
> Assignee: Venkata Jyothsna Donapati
> Fix For: Future
>
>
> In Drill, session options should take precedence over config options. But
> several of these session options are assigned hard-coded default values when
> the option validators are initialized. Because of this config options will
> never be read and honored even if the user did not specify the session
> option.
> ClassCompilerSelector.JAVA_COMPILER_VALIDATOR uses CompilerPolicy.DEFAULT as
> the default value. This default value gets into the session options map via
> the initialization of validators in SystemOptionManager.
> Now any piece of code that tries to check if a session option is set will
> never see a null, so it will always use that value and never try to look into
> the config options. For example, in the following piece of code from
> ClassCompilerSelector (), the policy will never be read from the config file.
> policy = CompilerPolicy.valueOf((value != null) ?
> value.string_val.toUpperCase() :
> config.getString(JAVA_COMPILER_CONFIG).toUpperCase());
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
