[ 
https://issues.apache.org/jira/browse/DRILL-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105659#comment-16105659
 ] 

ASF GitHub Bot commented on DRILL-5663:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/874#discussion_r130183310
  
    --- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
    @@ -338,3 +338,11 @@ drill.exec: {
     drill.jdbc: {
       batch_queue_throttling_threshold: 100
     }
    +javax.net.ssl.keyStore = ""
    +ssl.keyStorePath = ${?javax.net.ssl.keyStore}
    +javax.net.ssl.keyStorePassword = ""
    +ssl.keyStorePassword = ${?javax.net.ssl.keyStorePassword}
    +javax.net.ssl.trustStore = ""
    +ssl.trustStorePath = ${?javax.net.ssl.trustStore}
    +javax.net.ssl.trustStorePassword = ""
    +ssl.trustStorePassword =  ${?javax.net.ssl.trustStorePassword}
    --- End diff --
    
    Add a comment about the `javax` versions being legacy and deprecated.
    
    ```
    javax.net.ssl: {
      keyStorePath = ...
      ...
    }
    drill.exec.ssl {
      keyStorePath = "",
      ...
    }
    ```
    
    Better, move the `drill.exec` stuff under the existing `drill.exec` section.


> Drillbit fails to start when only keystore path is provided without keystore 
> password.
> --------------------------------------------------------------------------------------
>
>                 Key: DRILL-5663
>                 URL: https://issues.apache.org/jira/browse/DRILL-5663
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sindhuri Ramanarayan Rayavaram
>
> When we configure keystore path without keystore password inside 
> drill-override.conf for WebServer, then Drillbit fails to start. We should 
> explicitly check for either both being present or both being absent. If any 
> one of them is only present then throw startup exception for Drill.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to