[ 
https://issues.apache.org/jira/browse/DRILL-5699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114504#comment-16114504
 ] 

ASF GitHub Bot commented on DRILL-5699:
---------------------------------------

Github user sindhurirayavaram commented on the issue:

    https://github.com/apache/drill/pull/891
  
    @arina-ielchiieva After the first commit, I had a detailed discussion with 
@parthchandra. There are two reasons two include all the js and css files 
locally
    1) The biggest library among them, the jquery is already included in the 
resources file. Even libraries like d3 are there locally.
    2) One of the js and css libraries, Colvis by datatables is retired. We 
have to keep a local copy of that incase the url becomes extinct in the future. 
Check this please [Colvis](https://datatables.net/extensions/colvis/) 
     So we decided to just include all the js and css libraries locally. I 
updated the libraries to their min versions and some of them to their latest 
versions. I made a change in generic page where we are loading google external 
cdn first and if its failing falling back to the local library. Please let me 
know if there are any changes needed here. Thank you. 


> Drill Web UI Page Source Has Links To External Sites
> ----------------------------------------------------
>
>                 Key: DRILL-5699
>                 URL: https://issues.apache.org/jira/browse/DRILL-5699
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>            Reporter: Sindhuri Ramanarayan Rayavaram
>            Assignee: Sindhuri Ramanarayan Rayavaram
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> Drill uses external CDN for javascript and css files in the result page. When 
> there is no internet connection this page fails to load. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to