[
https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135312#comment-16135312
]
ASF GitHub Bot commented on DRILL-5717:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r134260296
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
---
@@ -51,9 +51,9 @@ public void testIsDate() throws Exception {
.sqlQuery("select case when isdate(date1) then cast(date1 as date)
else null end res1 from " + dateValues)
.unOrdered()
.baselineColumns("res1")
- .baselineValues(new DateTime(Date.valueOf("1900-01-01").getTime()))
- .baselineValues(new DateTime(Date.valueOf("3500-01-01").getTime()))
- .baselineValues(new DateTime(Date.valueOf("2000-12-31").getTime()))
+ .baselineValues(new DateTime(1900,1,1,0,0))
+ .baselineValues(new DateTime(3500,1,1,0,0))
+ .baselineValues(new DateTime(2000,12,31,0,0))
--- End diff --
Please add spaces after the comma.
> date time test cases is not Local independent
> ---------------------------------------------
>
> Key: DRILL-5717
> URL: https://issues.apache.org/jira/browse/DRILL-5717
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.9.0, 1.11.0
> Reporter: weijie.tong
>
> Some date time test cases like JodaDateValidatorTest is not Local
> independent .This will cause other Local's users's test phase to fail. We
> should let these test cases to be Local env independent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
