[ 
https://issues.apache.org/jira/browse/DRILL-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163725#comment-16163725
 ] 

ASF GitHub Bot commented on DRILL-5752:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/940#discussion_r138473108
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSimpleExternalSort.java
 ---
    @@ -148,10 +149,10 @@ public void sortOneKeyDescendingExternalSortLegacy() 
throws Throwable {
     
       private void sortOneKeyDescendingExternalSort(boolean testLegacy) throws 
Throwable {
         FixtureBuilder builder = ClusterFixture.builder()
    -        .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_SPILL_GROUP_SIZE, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_BATCH_LIMIT, 4)
    -        .configProperty(ExecConstants.EXTERNAL_SORT_DISABLE_MANAGED, false)
    +        .configProperty(OptionValidator.OPTION_DEFAULTS_ROOT + 
ExecConstants.EXTERNAL_SORT_SPILL_THRESHOLD, 4)
    --- End diff --
    
    These options are boot options, not runtime options, so no need for the 
prefix (unless someone changed something.)


> Speed Up Unit Tests
> -------------------
>
>                 Key: DRILL-5752
>                 URL: https://issues.apache.org/jira/browse/DRILL-5752
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>
> Tests can be split into categories.
> High-level categories:
> * Fast
> * Slow
> Low-level categories:
> * Vector
> * WebUI
> * Planner
> * Operator
> * Storage
> * Hive
> * JDBC
> * Kudu
> * Mongo
> * Hbase
> After the tests are categorized the Travis build can just run the fast tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to