[
https://issues.apache.org/jira/browse/DRILL-5772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165141#comment-16165141
]
ASF GitHub Bot commented on DRILL-5772:
---------------------------------------
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/936
@arina-ielchiieva, my comments boil down to two points:
1. What happens if UTF-8 support in Drill is disabled? Do we have
consistent handling of character data? Do we revert to ASCII? The character set
on the Drillbit? How is this reconciled with the character set on the Web and
the client?
2. On the other hand, if Drill handles only UTF-8 (with bugs), does it make
sense to disable that support if the alternative is undefined or more broken
than the UTF-8 support?
In short: shouldn't UTF-8 be the hard-coded by Drill when working with
Calcite to avoid these ambiguities?
> Add unit tests to indicate how utf-8 support can be enabled / disabled in
> Drill
> -------------------------------------------------------------------------------
>
> Key: DRILL-5772
> URL: https://issues.apache.org/jira/browse/DRILL-5772
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.11.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Labels: doc-impacting
> Fix For: 1.12.0
>
>
> Add unit test to indicated how utf-8 support can be enabled in Drill.
> To select utf-8 data user needs to update system property
> {{saffron.default.charset}} to {{UTF-16LE}} before starting the drillbit.
> Calcite uses this property to get default charset, if it is not set then
> {{ISO-8859-1}} is used by default. Drill gets default charset from Calcite.
> This information should be also documented, probably in
> https://drill.apache.org/docs/data-type-conversion/.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
