[
https://issues.apache.org/jira/browse/DRILL-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173618#comment-16173618
]
ASF GitHub Bot commented on DRILL-5781:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/942#discussion_r139273842
--- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/ExecTest.java
---
@@ -100,6 +101,14 @@ public void run() {
return dir.getAbsolutePath() + File.separator + dirName;
}
+ /**
+ * Sets zookeeper server and client SASL test config properties.
+ */
+ public static void setZookeeperSaslTestConfigProps() {
--- End diff --
Maybe it's possible to create separate test zk util class with this method
and also setup for jaas property (so jaas config is not repeated twice in the
code) and keep it in the same package where we test zk?
> Fix unit test failures to use tests config even if default config is available
> ------------------------------------------------------------------------------
>
> Key: DRILL-5781
> URL: https://issues.apache.org/jira/browse/DRILL-5781
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.11.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
> Fix For: 1.12.0
>
>
> Unit tests fail when they are run with the mapr profile.
> Tests failures, connected with the Zookeeper configuration that differs from
> expected:
> {noformat}
> DrillClientTest>TestWithZookeeper.setUp:32 » Runtime java.io.IOException:
> Coul...
> TestZookeeperClient.testPutWithMatchingVersion » IO Could not configure
> server...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testStartingClientEnablesCacheAndEnsuresRootNodeExists
> » IO
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testHasPathThrowsDrillRuntimeException » IO Could not
> conf...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testHasPathFalseWithVersion » IO Could not configure
> serve...
> TestZookeeperClient.tearDown:86 NullPointer
> TestEphemeralStore.testPutAndGetWorksAntagonistacally » IO Could not
> configure...
> TestEphemeralStore.tearDown:132 NullPointer
> TestZookeeperClient.testGetWithVersion » IO Could not configure server
> because...
> TestZookeeperClient.tearDown:86 NullPointer
> TestEphemeralStore.testStoreRegistersDispatcherAndStartsItsClient » IO
> Could n...
> TestEphemeralStore.tearDown:132 NullPointer
> TestZookeeperClient.testPutWithNonMatchingVersion » IO Could not configure
> ser...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testGetWithEventualConsistencyHitsCache » IO Could not
> con...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testPutIfAbsentWhenPresent » IO Could not configure
> server...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testHasPathTrueWithVersion » IO Could not configure
> server...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testPutAndGetWorks » IO Could not configure server
> because...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testPutIfAbsentWhenAbsent » IO Could not configure
> server ...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testHasPathWithEventualConsistencyHitsCache » IO Could
> not...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testCreate » IO Could not configure server because SASL
> co...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testDelete » IO Could not configure server because SASL
> co...
> TestZookeeperClient.tearDown:86 NullPointer
> TestZookeeperClient.testEntriesReturnsRelativePaths » IO Could not
> configure s...
> TestZookeeperClient.tearDown:86 NullPointer
> TestPStoreProviders>TestWithZookeeper.setUp:32 » Runtime java.io.IOException:
> ...
> TestPauseInjection.pauseOnSpecificBit:151 » Runtime java.io.IOException:
> Could...
> TestExceptionInjection.injectionOnSpecificBit:217 » Runtime
> java.io.IOExceptio...
> HBaseTestsSuite.initCluster:110 » IO No JAAS configuration section named
> 'Serv...
> {noformat}
> Test failures, connected with Hadoop configuration that differs from expected:
> {noformat}
> TestInboundImpersonation.setup:58->BaseTestImpersonation.startMiniDfsCluster:80->BaseTestImpersonation.startMiniDfsCluster:111
> » ClassCast
>
> TestImpersonationMetadata.setup:58->BaseTestImpersonation.startMiniDfsCluster:80->BaseTestImpersonation.startMiniDfsCluster:111
> » ClassCast
>
> TestImpersonationDisabledWithMiniDFS.setup:37->BaseTestImpersonation.startMiniDfsCluster:106
> » Runtime
>
> TestImpersonationQueries.setup:46->BaseTestImpersonation.startMiniDfsCluster:80->BaseTestImpersonation.startMiniDfsCluster:111
> » ClassCast
> TestHiveStorage>HiveTestBase.generateHive:34 » Runtime
> java.lang.RuntimeExcept...
> TestInfoSchemaOnHiveStorage>HiveTestBase.generateHive:34 » Runtime
> java.lang.R...
> TestInbuiltHiveUDFs>HiveTestBase.generateHive:35 » ExecutionSetup Failure
> sett...
> TestSampleHiveUDFs>HiveTestBase.generateHive:35 » ExecutionSetup Failure
> setti...
>
> TestStorageBasedHiveAuthorization.setup:109->BaseTestImpersonation.startMiniDfsCluster:80->BaseTestImpersonation.startMiniDfsCluster:111
> » ClassCast
>
> TestSqlStdBasedAuthorization.setup:72->BaseTestImpersonation.startMiniDfsCluster:80->BaseTestImpersonation.startMiniDfsCluster:111
> » ClassCast
> TestHivePartitionPruning>HiveTestBase.generateHive:35 » ExecutionSetup
> Failure...
> TestViewSupportOnHiveTables.generateHive:35 » ExecutionSetup Failure
> setting u...
> TestHiveProjectPushDown>HiveTestBase.generateHive:35 » ExecutionSetup
> Failure ...
> {noformat}
> Test specific configuration should be added to fix these failures.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
