[
https://issues.apache.org/jira/browse/DRILL-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180035#comment-16180035
]
ASF GitHub Bot commented on DRILL-5809:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/957#discussion_r140936599
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/server/options/PersistedOptionValueTest.java
---
@@ -0,0 +1,226 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.drill.exec.server.options;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.drill.common.util.FileUtils;
+import org.apache.drill.exec.serialization.JacksonSerializer;
+import org.apache.drill.exec.store.sys.PersistentStoreConfig;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.IOException;
+
+public class PersistedOptionValueTest {
+ /**
+ * DRILL-5809
+ * Note: If this test breaks you are probably breaking backward and
forward compatibility. Verify with the community
--- End diff --
Great comment!
> Queries failed with UnrecognizedPropertyException
> -------------------------------------------------
>
> Key: DRILL-5809
> URL: https://issues.apache.org/jira/browse/DRILL-5809
> Project: Apache Drill
> Issue Type: Bug
> Components: Functions - Drill
> Affects Versions: 1.12.0
> Environment: RHEL 6, 2.6.32-358.el6.x86_64, Apache Drill gitid
> 4c99f0cdd98b1a0e789c5d11b353f88a2f6d54aa
> Reporter: Dechang Gu
> Assignee: Timothy Farkas
> Priority: Blocker
> Fix For: 1.12.0
>
>
> Run tpch queries, all failed due to the following error:
> {code}
> java.sql.SQLException: SYSTEM ERROR: UnrecognizedPropertyException:
> Unrecognized field "type" (class
> org.apache.drill.exec.server.options.OptionValue), not marked as ignorable (8
> known properties: "string_val", "kind", "accessibleScopes", "num_val",
> "name", "bool_val", "float_val", "scope"])
> at [Source: [B@4ec364a3; line: 6, column: 2] (through reference chain:
> org.apache.drill.exec.server.options.OptionValue["type"])
> [Error Id: 9bad34d9-fe21-47fd-ade1-fbee3d5111e5 on ucs-node7.perf.lab:31010]
> at
> org.apache.drill.jdbc.impl.DrillCursor.nextRowInternally(DrillCursor.java:489)
> at
> org.apache.drill.jdbc.impl.DrillCursor.loadInitialSchema(DrillCursor.java:561)
> at
> org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:1895)
> at
> org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:61)
> at
> org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnection.java:473)
> at
> org.apache.drill.jdbc.impl.DrillMetaImpl.prepareAndExecute(DrillMetaImpl.java:1100)
> at
> org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:477)
> at
> org.apache.drill.jdbc.impl.DrillConnectionImpl.prepareAndExecuteInternal(DrillConnectionImpl.java:181)
> at
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:109)
> at
> org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:130)
> at
> org.apache.drill.jdbc.impl.DrillStatementImpl.executeQuery(DrillStatementImpl.java:112)
> at PipSQueak.executeQuery(PipSQueak.java:289)
> at PipSQueak.runTest(PipSQueak.java:104)
> at PipSQueak.main(PipSQueak.java:477)
> Caused by: org.apache.drill.common.exceptions.UserRemoteException: SYSTEM
> ERROR: UnrecognizedPropertyException: Unrecognized field "type" (class
> org.apache.drill.exec.server.options.OptionValue), not marked as ignorable (8
> known properties: "string_val", "kind", "accessibleScopes", "num_val",
> "name", "bool_val", "float_val", "scope"])
> at [Source: [B@4ec364a3; line: 6, column: 2] (through reference chain:
> org.apache.drill.exec.server.options.OptionValue["type"])
> {code}
> Looks like the issue was introduced in commit:
> 6adeb986016a769755fd5e8fc66244ee1e8d18e1
> DRILL-5723: Added System Internal Options That can be Modified at Run…
> The commit prior to this one did not show the issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
