[
https://issues.apache.org/jira/browse/DRILL-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181631#comment-16181631
]
ASF GitHub Bot commented on DRILL-5259:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/963#discussion_r141192014
--- Diff: exec/java-exec/src/main/resources/rest/profile/list.ftl ---
@@ -37,7 +37,15 @@
<strong>No running queries.</strong>
</div>
</#if>
- <h3>Completed Queries</h3>
+ <table width="100%">
+ <tr>
+ <td><h3>Completed Queries</h3></td>
+ <td align="right">
+ <form action="/profiles" method="get"><span title="Max number of
profiles to list">Show </span>
+ <input id="fetchMax" type="text" size="7" name="max"
value="${model.getFinishedQueries()?size}">
+ <input type="submit" value="Go">
+ </form></td>
+ </tr></table>
--- End diff --
BTW: we should validate the max parameter in the Java code. Force max into
the range: 1 ... 500 (say).
That is, don't allow -1, 0 or 1000000 profiles.
> Allow listing a user-defined number of profiles
> ------------------------------------------------
>
> Key: DRILL-5259
> URL: https://issues.apache.org/jira/browse/DRILL-5259
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.9.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Trivial
> Fix For: 1.10.0, 1.12.0
>
>
> Currently, the web UI only lists the last 100 profiles.
> This count is currently hard coded. The proposed change would be to create an
> option in drill-override.conf to provide a flexible default value, and also
> an option within the UI (via optional parameter in the path).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
