[
https://issues.apache.org/jira/browse/DRILL-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206638#comment-16206638
]
ASF GitHub Bot commented on DRILL-5873:
---------------------------------------
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/992#discussion_r144977545
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.cpp ---
@@ -678,7 +678,10 @@ connectionStatus_t
DrillClientImpl::handleAuthentication(const DrillUserProperti
m_io_service.reset();
return CONN_SUCCESS;
} else {
- logMsg << m_encryptionCtxt << ", Error: " << m_saslResultCode;
+ logMsg << m_encryptionCtxt
+ << ", Mechanism: " <<
m_saslAuthenticator->getAuthMechanismName()
+ << ", Error: " << m_saslResultCode
+ << ", Cause: " <<
m_saslAuthenticator->getErrorMessage(m_saslResultCode);
--- End diff --
How about adding this cause message string in the [if
condition](https://github.com/apache/drill/pull/992/files#diff-8e6df071d8ca863fcfa578892944c1dcR661)
too ?
> Drill C++ Client should throw proper/complete error message for the ODBC
> driver to consume
> ------------------------------------------------------------------------------------------
>
> Key: DRILL-5873
> URL: https://issues.apache.org/jira/browse/DRILL-5873
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - C++
> Reporter: Krystal
> Assignee: Parth Chandra
>
> The Drill C++ Client should throw a proper/complete error message for the
> driver to utilize.
> The ODBC driver is directly outputting the exception message thrown by the
> client by calling the getError() API after the connect() API has failed with
> an error status.
> For the Java client, similar logic is hard coded at
> https://github.com/apache/drill/blob/1.11.0/exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java#L247.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
