[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211757#comment-16211757
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user ilooner commented on a diff in the pull request:
https://github.com/apache/drill/pull/984#discussion_r145827440
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/TestAltSortQueries.java ---
@@ -64,9 +73,9 @@ public void testJoinWithLimit() throws Exception{
" nations.N_NAME,\n" +
" regions.R_NAME\n" +
"FROM\n" +
- " dfs_test.`[WORKING_PATH]/../../sample-data/nation.parquet`
nations\n" +
+ " dfs.`/sample-data/nation.parquet` nations\n" +
--- End diff --
I accidentally changed it to dfs, will switch it back to dfs_test for
consistency. <b>dfs</b> and <b>dfs_test>/b> are configured to point to the same
temp directories so they are in fact interchangeable. This configuration
happens in the openClient method of BaseTestQuery and in the
configureStoragePlugins method of the ClusterFixture.
Throughout making this change I was scratching my head as to why
<b>dfs_test</b> is used instead of <b>dfs<b>. After going through the code I
don't see any reason as to why dfs_test was created in the first place. I think
we should actually remove <b>dfs_test</b> and just use <b>dfs</b> everywhere
for uniformity. I'll go ahead and do that now.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
