[ 
https://issues.apache.org/jira/browse/DRILL-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217460#comment-16217460
 ] 

ASF GitHub Bot commented on DRILL-5896:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1005#discussion_r146659717
  
    --- Diff: 
contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
 ---
    @@ -186,6 +192,10 @@ public void setup(OperatorContext context, 
OutputMutator output) throws Executio
               }
             }
           }
    +
    +      for (String familyName : completeFamilies) {
    +        getOrCreateFamilyVector(familyName, false);
    +      }
    --- End diff --
    
    Does this create just the map, or also the vectors within the map? Maybe a 
comment to explain the goals?


> Handle vector creation in HbaseRecordReader to avoid NullableInt vectors later
> ------------------------------------------------------------------------------
>
>                 Key: DRILL-5896
>                 URL: https://issues.apache.org/jira/browse/DRILL-5896
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - HBase
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>             Fix For: 1.12.0
>
>
> When a hbase query projects both a column family and a column in the column 
> family, the vector for the column is not created in the HbaseRecordReader.
> So, in cases where scan batch is empty we create a NullableInt vector for 
> this column. We need to handle column creation in the reader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to