[ https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224023#comment-16224023 ]
ASF GitHub Bot commented on DRILL-5717: --------------------------------------- Github user vvysotskyi commented on a diff in the pull request: https://github.com/apache/drill/pull/904#discussion_r147582599 --- Diff: logical/src/test/java/org/apache/drill/common/expression/fn/JodaDateValidatorTest.java --- @@ -24,6 +24,7 @@ import org.junit.BeforeClass; import org.junit.Test; +import java.util.Locale; --- End diff -- Could you please revert changes, made in this class to the version, where you just added `.withLocale(Locale.US)` in `parseDateFromPostgres` method. My earlier comment was connected only with change, made in UDF function, but here, in the method that just used for unit tests, we can do that. > change some date time unit cases with specific timezone or Local > ---------------------------------------------------------------- > > Key: DRILL-5717 > URL: https://issues.apache.org/jira/browse/DRILL-5717 > Project: Apache Drill > Issue Type: Bug > Components: Tools, Build & Test > Affects Versions: 1.9.0, 1.11.0 > Reporter: weijie.tong > > Some date time test cases like JodaDateValidatorTest is not Local > independent .This will cause other Local's users's test phase to fail. We > should let these test cases to be Local env independent. -- This message was sent by Atlassian JIRA (v6.4.14#64029)