[ https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234797#comment-16234797 ]
ASF GitHub Bot commented on DRILL-5783: --------------------------------------- Github user ilooner commented on a diff in the pull request: https://github.com/apache/drill/pull/984#discussion_r148394268 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestExternalSort.java --- @@ -138,34 +141,34 @@ public void testNewColumnsManaged() throws Exception { testNewColumns(false); } - @Test public void testNewColumnsLegacy() throws Exception { testNewColumns(true); } private void testNewColumns(boolean testLegacy) throws Exception { final int record_count = 10000; - String dfs_temp = getDfsTestTmpSchemaLocation(); - System.out.println(dfs_temp); - File table_dir = new File(dfs_temp, "newColumns"); - table_dir.mkdir(); - try (BufferedOutputStream os = new BufferedOutputStream(new FileOutputStream(new File(table_dir, "a.json")))) { - String format = "{ a : %d, b : %d }%n"; - for (int i = 0; i <= record_count; i += 2) { - os.write(String.format(format, i, i).getBytes()); - } + final String tableDirName = "newColumns"; + + TableFileBuilder tableA = new TableFileBuilder(Lists.newArrayList("a", "b"), Lists.newArrayList("%d", "%d")); --- End diff -- I've made the JsonFileBuilder, which takes a RowSet and writes it out to a file as json. > Make code generation in the TopN operator more modular and test it > ------------------------------------------------------------------ > > Key: DRILL-5783 > URL: https://issues.apache.org/jira/browse/DRILL-5783 > Project: Apache Drill > Issue Type: Improvement > Reporter: Timothy Farkas > Assignee: Timothy Farkas > Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029)