[
https://issues.apache.org/jira/browse/DRILL-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238248#comment-16238248
]
ASF GitHub Bot commented on DRILL-4286:
---------------------------------------
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/921#discussion_r148676672
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -200,11 +206,47 @@ public void unregister(RegistrationHandle handle) {
}
}
+ /**
+ * Update drillbit endpoint state. Drillbit advertises its
+ * state in Zookeeper when a shutdown request of drillbit is
+ * triggered. State information is used during planning and
+ * initial client connection phases.
+ */
+ public RegistrationHandle update(RegistrationHandle handle, State state)
{
+ ZKRegistrationHandle h = (ZKRegistrationHandle) handle;
+ try {
+ endpoint = h.endpoint.toBuilder().setState(state).build();
+ ServiceInstance<DrillbitEndpoint> serviceInstance =
ServiceInstance.<DrillbitEndpoint>builder().name(serviceName).id(h.id).payload(endpoint).build();
--- End diff --
suggestion: wrap this long line since you have already wrapped the other
lines and comments
> Have an ability to put server in quiescent mode of operation
> ------------------------------------------------------------
>
> Key: DRILL-4286
> URL: https://issues.apache.org/jira/browse/DRILL-4286
> Project: Apache Drill
> Issue Type: New Feature
> Components: Execution - Flow
> Reporter: Victoria Markman
> Assignee: Venkata Jyothsna Donapati
> Priority: Major
>
> I think drill will benefit from mode of operation that is called "quiescent"
> in some databases.
> From IBM Informix server documentation:
> {code}
> Change gracefully from online to quiescent mode
> Take the database server gracefully from online mode to quiescent mode to
> restrict access to the database server without interrupting current
> processing. After you perform this task, the database server sets a flag that
> prevents new sessions from gaining access to the database server. The current
> sessions are allowed to finish processing. After you initiate the mode
> change, it cannot be canceled. During the mode change from online to
> quiescent, the database server is considered to be in Shutdown mode.
> {code}
> This is different from shutdown, when processes are terminated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
