[ 
https://issues.apache.org/jira/browse/DRILL-5337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239577#comment-16239577
 ] 

ASF GitHub Bot commented on DRILL-5337:
---------------------------------------

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/774
  
    @Vlad-Storona I have deployed your branch and have noticed several more 
issues:
    1. When I openTSDB storage plugin tab for the first time, its content is 
showing as null.
    2. When I have indicated incorrect connection, the following exception is 
displayed in the log:
    ```
     org.apache.drill.common.exceptions.ExecutionSetupException: Failure 
setting up new storage plugin configuration for config 
org.apache.drill.exec.store.openTSDB.OpenTSDBStoragePluginConfig@a837d5e8
    ```
    3. When I try to query with incorrect syntax, the following error is 
displayed:
    ```
     0: jdbc:drill:drillbit=localhost> select * from `mymetric.stock`;
    Error: SYSTEM ERROR: IllegalArgumentException: Chunk [mymetric.stock] is 
not a valid entry
     
     Caused by: java.lang.IllegalArgumentException: Chunk [mymetric.stock] is 
not a valid entry
        at 
com.google.common.base.Preconditions.checkArgument(Preconditions.java:145) 
~[guava-18.0.jar:na]
        at com.google.common.base.Splitter$MapSplitter.split(Splitter.java:508) 
~[guava-18.0.jar:na]
    ```
    4. When I try to enable storage plugin config with incorrect connection, it 
fails. I think we should allow enabling config even if we could not connect to 
openTSDB as others plugins do but fail when we try to query the data.


> OpenTSDB storage plugin
> -----------------------
>
>                 Key: DRILL-5337
>                 URL: https://issues.apache.org/jira/browse/DRILL-5337
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Storage - Other
>            Reporter: Dmitriy Gavrilovych
>            Assignee: Dmitriy Gavrilovych
>              Labels: features
>             Fix For: 1.12.0
>
>
> Storage plugin for OpenTSDB
> The plugin uses REST API to work with TSDB. 
> Expected queries are listed below:
> SELECT * FROM openTSDB.`warp.speed.test`;
> Return all elements from warp.speed.test table with default aggregator SUM
> SELECT * FROM openTSDB.`(metric=warp.speed.test)`;
> Return all elements from (metric=warp.speed.test) table as a previous query, 
> but with alternative FROM syntax
> SELECT * FROM openTSDB.`(metric=warp.speed.test, aggregator=avg)`;
> Return all elements from warp.speed.test table, but with the custom aggregator
> SELECT `timestamp`, sum(`aggregated value`) FROM 
> openTSDB.`(metric=warp.speed.test, aggregator=avg)` GROUP BY `timestamp`;
> Return aggregated and grouped value by standard drill functions from 
> warp.speed.test table, but with the custom aggregator
> SELECT * FROM openTSDB.`(metric=warp.speed.test, downsample=5m-avg)`
> Return data limited by downsample



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to