[
https://issues.apache.org/jira/browse/DRILL-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245834#comment-16245834
]
ASF GitHub Bot commented on DRILL-5921:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1020#discussion_r149994673
--- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
@@ -138,21 +154,14 @@
});
};
- function updateOthers(metrics) {
- $.each(["counters", "meters"], function(i, key) {
- if(! $.isEmptyObject(metrics[key])) {
- $("#" + key + "Val").html(JSON.stringify(metrics[key], null, 2));
- }
- });
- };
-
var update = function() {
$.get("/status/metrics", function(metrics) {
updateGauges(metrics.gauges);
updateBars(metrics.gauges);
if(! $.isEmptyObject(metrics.timers)) createTable(metrics.timers,
"timers");
if(! $.isEmptyObject(metrics.histograms))
createTable(metrics.histograms, "histograms");
- updateOthers(metrics);
+ if(! $.isEmptyObject(metrics.counters))
createCountersTable(metrics.counters);
+ if(! $.isEmptyObject(metrics.meters))
$("#metersVal").html(JSON.stringify(metrics.meters, null, 2));
--- End diff --
Well, sounds good then, thanks for making the changes.
> Counters metrics should be listed in table
> ------------------------------------------
>
> Key: DRILL-5921
> URL: https://issues.apache.org/jira/browse/DRILL-5921
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
> Affects Versions: 1.11.0
> Reporter: Prasad Nagaraj Subramanya
> Assignee: Prasad Nagaraj Subramanya
> Priority: Minor
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Counter metrics are currently displayed as json string in the Drill UI. They
> should be listed in a table similar to other metrics.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
