[
https://issues.apache.org/jira/browse/DRILL-5783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248288#comment-16248288
]
ASF GitHub Bot commented on DRILL-5783:
---------------------------------------
Github user ilooner commented on the issue:
https://github.com/apache/drill/pull/984
After squashing the commits and rebasing I noticed the windows functional
tests were failing. The issue was caused by replacing the '/' constant in
FileUtils (now renamed to DrillFileUtils) in **ClassTransformer** and
**FunctionInitializer** with File.separator. This broke the build because
File.separator is '\' on windows and in the context of **ClassTransformer** and
**FunctionInitializer** the separator is used to look things up in the
classpath. Looking things up in the classpath requires '/' on both windows and
linux, hence I added back the '/' constant to DrillFileUtils along with a
comment explaining its purpose and used it in **ClassTransformer** and
**FunctionInitializer**. *Note:* this was a minor fix that impacted only a few
lines.
> Make code generation in the TopN operator more modular and test it
> ------------------------------------------------------------------
>
> Key: DRILL-5783
> URL: https://issues.apache.org/jira/browse/DRILL-5783
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> The work for this PR has had several other PRs batched together with it. The
> full description of work is the following:
> DRILL-5783
> * A unit test is created for the priority queue in the TopN operator
> * The code generation classes passed around a completely unused function
> registry reference in some places so I removed it.
> * The priority queue had unused parameters for some of its methods so I
> removed them.
> DRILL-5841
> * There were many many ways in which temporary folders were created in unit
> tests. I have unified the way these folders are created with the
> DirTestWatcher, SubDirTestWatcher, and BaseDirTestWatcher. All the unit tests
> have been updated to use these. The test watchers create temp directories in
> ./target//. So all the files generated and used in the context of a test can
> easily be found in the same consistent location.
> * This change should fix the sporadic hashagg test failures, as well as
> failures caused by stray files in /tmp
> DRILL-5894
> * dfs_test is used as a storage plugin throughout the unit tests. This is
> highly confusing and we can just use dfs instead.
> *Misc*
> * General code cleanup.
> * There are many places where String.format is used unnecessarily. The test
> builder methods already use String.format for you when you pass them args. I
> cleaned some of these up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
